scan RHS of dropped assignments#1581
Merged
alexlamsl merged 1 commit intomishoo:masterfrom Mar 8, 2017
Merged
Conversation
- similar case as mishoo#1578 but against mishoo#1450 instead - fix `this` binding in mishoo#1450 as well closes mishoo#1580
Contributor
|
Seems you've dropped the while loop and let the optimizer do its job locally and the rest would take care of itself? LGTM |
Collaborator
Author
Yes - |
Collaborator
Author
|
Thanks for the review 👍 |
Contributor
You are a wizard of DRY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar case as #1578 but against the missing branch of #1450 instead.
Also fixed
thisbinding issue when dropping assignments.