smarter const replacement taking name length into account#1459
Closed
kzc wants to merge 1 commit intomishoo:masterfrom
kzc:smarter_const_replace
Closed
smarter const replacement taking name length into account#1459kzc wants to merge 1 commit intomishoo:masterfrom kzc:smarter_const_replace
kzc wants to merge 1 commit intomishoo:masterfrom
kzc:smarter_const_replace
Conversation
Collaborator
|
Interesting maths. Changes don't conflict from any existing PRs queued for 2.7.5 as well, I think. LGTM |
Merged
Contributor
Author
|
I changed this PR to deem |
Contributor
Author
|
Perhaps Edit: spelling fixed for |
alexlamsl
pushed a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Feb 18, 2017
Collaborator
|
Now that I've merged #1498, I see we can extend the logic here to include variables as well. Would that be undesirable? |
Collaborator
|
On second thought, let's worry about that in another PR after 2.8.0 |
Contributor
Author
|
@alexlamsl That would be a good addition post 2.8.0. |
This was referenced Feb 24, 2017
Merged
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Nov 3, 2017
Reverts mishoo#1459 back to simple replacements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1191, #1194, #1396