Skip to content

enable collapse_vars & reduce_vars by default#1498

Closed
alexlamsl wants to merge 1 commit intomishoo:masterfrom
alexlamsl:remove_const_pragma
Closed

enable collapse_vars & reduce_vars by default#1498
alexlamsl wants to merge 1 commit intomishoo:masterfrom
alexlamsl:remove_const_pragma

Conversation

@alexlamsl
Copy link
Copy Markdown
Collaborator

@alexlamsl alexlamsl commented Feb 21, 2017

fixes #1497

@alexlamsl
Copy link
Copy Markdown
Collaborator Author

alexlamsl commented Feb 21, 2017

In theory we can remove any special case treatment of const altogether, but given that reduce_vars is off by default let's leave it be for now. Plus it's less intrusive this way.

@alexlamsl alexlamsl changed the title deprecate /*@const*/ enable collapse_vars & reduce_vars by default Feb 23, 2017
@kzc
Copy link
Copy Markdown
Contributor

kzc commented Feb 23, 2017 •
edited
Loading

+1 on enabling these optimizations by default.

@alexlamsl
Copy link
Copy Markdown
Collaborator Author

alexlamsl commented Feb 23, 2017

@kzc oops, I forgot you use SymbolDef.constant in #1459 - let me restore those lines

@alexlamsl
enable collapse_vars & reduce_vars by default
afc3108 
- fix corner cases in `const` optimisation
- deprecate `/*@const*/`

fixes mishoo#1497
This was referenced Feb 23, 2017
Merged
Closed
@alexlamsl alexlamsl closed this in 4e49302 Feb 23, 2017
@alexlamsl alexlamsl deleted the remove_const_pragma branch February 24, 2017 00:28
@STRML STRML mentioned this pull request Mar 8, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@const creeping

2 participants

@alexlamsl @kzc