Merged
Conversation
edwintorok
approved these changes
May 20, 2025
Member
|
Thanks - not sure how we missed it. I'll cut a release. |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
May 28, 2025
CHANGES: - cohttp-mirage: make client usable again -- this fixes a regression introduced by mirage/ocaml-cohttp#1080 (@Firobe, review by @edwintorok, mirage/ocaml-cohttp#1110) - rename main function on README example (@Unn4m3DD, mirage/ocaml-cohttp#1097)
dkalinichenko-js
pushed a commit
to dkalinichenko-js/opam-repository
that referenced
this pull request
Jun 10, 2025
CHANGES: - cohttp-mirage: make client usable again -- this fixes a regression introduced by mirage/ocaml-cohttp#1080 (@Firobe, review by @edwintorok, mirage/ocaml-cohttp#1110) - rename main function on README example (@Unn4m3DD, mirage/ocaml-cohttp#1097)
Contributor
|
Ouch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0aa0416 unfortunately made the mirage client (or functor that takes it as argument) completely unusable, as the
failwiths are evaluated at module initialization.