chore: rename main function on main page example#1097
Merged
samoht merged 1 commit intomirage:mainfrom Mar 6, 2025
Merged
Conversation
Member
|
Good idea! Thanks for your contribution! |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
May 28, 2025
CHANGES: - cohttp-mirage: make client usable again -- this fixes a regression introduced by mirage/ocaml-cohttp#1080 (@Firobe, review by @edwintorok, mirage/ocaml-cohttp#1110) - rename main function on README example (@Unn4m3DD, mirage/ocaml-cohttp#1097)
dkalinichenko-js
pushed a commit
to dkalinichenko-js/opam-repository
that referenced
this pull request
Jun 10, 2025
CHANGES: - cohttp-mirage: make client usable again -- this fixes a regression introduced by mirage/ocaml-cohttp#1080 (@Firobe, review by @edwintorok, mirage/ocaml-cohttp#1110) - rename main function on README example (@Unn4m3DD, mirage/ocaml-cohttp#1097)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny pr renaming the main function on the first usage example of the lib.
Even though it probably looks like it, this is not a troll hacktoberfest I want my free t-shirt kind of PR.
I just picked up ocaml and this was the first code example I got up and running. I was very confused by the fact that there was this variable
bodyeverywhere and couldn't quite figure out what it meant. Then it clicked that there are indeed 2 variables called body each of which has nothing to do with each other.I believe many others will also start their ocaml journey by making some http requests and it would be great to have this example be more self explanatory.
This is even done later on this same readme under ## Basic server tutorial