Patches adding TLS support by talex5 · Pull Request #52 · mirage/mirage-dev

talex5 · 2015-01-15T14:53:46Z

This builds and tests everything with all the TLS patches in. I assume we now wait for these patches to be accepted upstream and update to the release archives as they happen?

Things needing to be merged/released:

And, afterwards:

Updated for Conduit TLS support mirage-skeleton#67

hannesm · 2015-01-15T22:22:53Z

should mirleft/ocaml-nocrypto#44 also be in this list??

talex5 · 2015-01-16T09:53:03Z

@hannesm you're right - I didn't realise that still wasn't merged. Is there a problem with it?

hannesm · 2015-01-16T09:59:02Z

@talex5 I think it's fine, but it's @pqwy territory (whom I keep busy with various PRs) ;)

talex5 · 2015-01-17T13:45:18Z

OK, I think we have all the required libraries in now! I added a Travis check to try building mirage-skeleton with --xen and also an https_website example that checks the TLS stuff builds for Xen.

avsm · 2015-01-23T14:14:49Z

mirage-console 2.1.1 in ocaml/opam-repository#3445

pqwy · 2015-01-26T16:48:53Z

mirleft/ocaml-nocrypto#44 can be crossed off the list too.

talex5 · 2015-01-26T16:51:29Z

@pqwy - not yet - it hasn't been released yet.

Required by latest TLS, which is required by latest conduit support.

The latest release was newer that our 0.7.1 version.

Mirage 2.2.1 is out.

avsm · 2015-03-04T18:21:50Z

tcpip.2.2.3 is now released, so checked that one off.

avsm · 2015-03-04T18:24:47Z

I've added a ctypes.0.4.0 working version in #55, as that's necessary for the Xen compilation.

hannesm · 2015-03-04T22:50:31Z

I believe mirage-entropy needs to be somewhere in here... and to get this released, mirage/mirage-platform#120 needs to be merged and released first..

avsm · 2015-03-04T23:40:20Z

mirage-platform 2.2.2 packages going out in ocaml/opam-repository#3667, so mirage-entropy is releasable now.

hannesm · 2015-03-10T18:59:28Z

there is no mirage-types-lwt-2.3.0?

avsm · 2015-03-10T19:06:07Z

am just adding it now!

avsm · 2015-03-10T19:11:34Z

ocaml/opam-repository#3694 has mirage-types-lwt.2.3.0

amirmc · 2015-03-11T17:46:10Z

Seems to me that mirleft/ocaml-nocrypto#44 was released. Checking it off this list.

talex5 · 2015-03-17T10:06:33Z

Seems various APIs had changed. I've updated the mirage and conduit PRs to the new APIs and removed the released components from this repository. Should be working again now.

hannesm · 2015-03-19T16:37:20Z

getting there... ocaml/opam-repository#3770

samoht · 2015-04-22T14:20:35Z

I've checked more boxes, the missing bits are cleaning-up out TLS support forconduit and solving the entropy/nocrypto coupling (which is worked on)

pqwy · 2015-04-23T01:05:49Z

That last bit is being tracked here.

hannesm · 2015-04-28T21:45:57Z

once mirage mirage/mirage#394 PR is merged, and there are some releases (nocrypto, tls, mirage-entropy-xen), we'll need gmp-xen and zarith-xen; which might both be sensible to drag in via a mirage-no-xen | (mirage-xen & x) dependency (zarith onto gmp, nocrypto onto zarith)..

samoht · 2015-04-28T21:54:23Z

Indeed, we need the mirage-no-xen stuff. Do you want to look into that tomorrow (I'm fine to do it too)?

hannesm · 2015-04-28T22:12:55Z

@samoht as a start #63

hannesm · 2015-04-29T18:34:11Z

would also be nice to release a mirage-xen which is compatible with cstruct-1.6.0 (e.g. master)

samoht · 2015-05-05T18:45:44Z

Almost done now, I've merged most of the things in mirage-dev. Only missing parts are optional but which would be nice to have:

support cstruct 1.6.0 in mirage-xen
better entropy and conduit integration (without mirage) Mirage Nocrypto initialise should be done within Lwt main loop ocaml-conduit#67

hannesm · 2015-05-05T19:39:34Z

@samoht great work, thanks! I believe #74 should be there as well. we can do some more testing, and then move it towards the main opam repository!?

samoht · 2015-05-05T19:47:20Z

Ha yes good point! Indeed, I plan to run a bit of more tests and then we can do a big pull-request to opam-repository with a coordinated announcement and blog post.

hannesm · 2015-05-11T14:43:22Z

this can be closed as well, or?

talex5 · 2015-05-11T16:52:25Z

The extra tests added to .travis-ci.sh are probably worth keeping (it now checks we can build mirage-skeleton for Xen, and also tests building a tls example). Apart from that, if the work is now happening on master then we can close this.

samoht · 2015-05-11T16:57:39Z

@talex5 can you create a new PR with your travis improvement? thanks!

talex5 · 2015-05-11T18:12:16Z

@samoht I've made a PR here: #77

The mirage-skeleton TLS example was for the old API, so I've left that out for now. I assume someone else has a test for the new API.

samoht · 2015-05-12T14:56:42Z

Thanks all for the efforts, we are almost seeing the light :-)

avsm · 2015-05-12T15:06:11Z

Just one thing I'm missing for the record: mirleft/ocaml-tls#250 (comment) -- will release this to get it working with cstruct 1.6.0 (@samoht tells me its cstruct 1.5.0 only atm)

hannesm · 2015-05-12T15:11:14Z

this PR in tls is intentionally not merged, to not introduce a dependency on cstruct-1.6.0. there are various other libraries (such as mirage-xen and dns) which required < cstruct-1.6.0.. will merge the tls PR (and maybe re-release) once releases of mirage-xen/dns/.. are done which support cstruct >= 1.6.0.

hannesm · 2015-05-12T15:12:18Z

also, keep in mind that tls-0.5.0 already works flawlessly with cstruct-1.6.0!

pqwy · 2015-05-13T15:44:15Z

Congrats, everyone!

This turned out to be soooo much hairier than initially expected... 😄

When the Vfs code got split out from the 9p support, the unique inode ID wasn't included. Instead, the 9p support started minting a new ID each time it was asked for one. This meant that clients saw a new inode number each time they asked for it. This confused cp at least, which checks that the inode number is the same before and after opening the file. Fixes mirage#52. Signed-off-by: Thomas Leonard <thomas.leonard@docker.com>

TLS patches

4e3bbc1

talex5 force-pushed the tls branch from d7e819c to 930cabb Compare January 16, 2015 15:04

mirage-net-xen changes are now merged

730ccf9

talex5 force-pushed the tls branch from 930cabb to 2c630bb Compare January 17, 2015 11:41

talex5 added 2 commits January 17, 2015 11:44

Added patched nocrypto

a45fefe

Test building mirage-skeleton for Xen

2c630bb

talex5 force-pushed the tls branch from c0f1f2d to f3ae903 Compare January 17, 2015 12:25

talex5 added 2 commits January 17, 2015 12:28

Added ctypes

f3ae903

Upstream ctypes doesn't work; use older commit

91b35ab

mirage-console.2.1.1 is out

1ae0779

talex5 added 7 commits January 27, 2015 14:37

Added new x509

0a0dcbe

Required by latest TLS, which is required by latest conduit support.

Added gmp opam dependency on ocamlfind

ca8426e

Changed conduit version to dev

ff9f101

The latest release was newer that our 0.7.1 version.

vchan 2.0.2 is out

6913f87

mirage-net-xen 1.3.0 is out

ec28f84

Changed mirage version to dev

622b7b6

Mirage 2.2.1 is out.

tcpip changes are merged

b76e501

talex5 mentioned this pull request Feb 10, 2015

Add notes from call on 2015-01-28 mirage/mirage-www#280

Merged

Merge remote-tracking branch 'origin/master' into tls

73978e1

samoht mentioned this pull request Mar 16, 2015

[RFC] Add TLS support in Conduit mirage/mirage#347

Merged

talex5 mentioned this pull request Mar 16, 2015

Tasks for getting OCaml-TLS working on Xen mirage/mirage#242

Closed

5 tasks

Removed released components

14fd9e0

samoht mentioned this pull request Apr 27, 2015

Support the new entropy mechanism for mirage/tls mirage/ocaml-conduit#64

Merged

samoht closed this May 12, 2015

Conversation

talex5 commented Jan 15, 2015

Uh oh!

hannesm commented Jan 15, 2015

Uh oh!

talex5 commented Jan 16, 2015

Uh oh!

hannesm commented Jan 16, 2015

Uh oh!

talex5 commented Jan 17, 2015

Uh oh!

avsm commented Jan 23, 2015

Uh oh!

pqwy commented Jan 26, 2015

Uh oh!

talex5 commented Jan 26, 2015

Uh oh!

avsm commented Mar 4, 2015

Uh oh!

avsm commented Mar 4, 2015

Uh oh!

hannesm commented Mar 4, 2015

Uh oh!

avsm commented Mar 4, 2015

Uh oh!

hannesm commented Mar 10, 2015

Uh oh!

avsm commented Mar 10, 2015

Uh oh!

avsm commented Mar 10, 2015

Uh oh!

amirmc commented Mar 11, 2015

Uh oh!

talex5 commented Mar 17, 2015

Uh oh!

hannesm commented Mar 19, 2015

Uh oh!

samoht commented Apr 22, 2015

Uh oh!

pqwy commented Apr 23, 2015

Uh oh!

hannesm commented Apr 28, 2015

Uh oh!

samoht commented Apr 28, 2015

Uh oh!

hannesm commented Apr 28, 2015

Uh oh!

hannesm commented Apr 29, 2015

Uh oh!

samoht commented May 5, 2015

Uh oh!

hannesm commented May 5, 2015

Uh oh!

samoht commented May 5, 2015

Uh oh!

hannesm commented May 11, 2015

Uh oh!

talex5 commented May 11, 2015

Uh oh!

samoht commented May 11, 2015

Uh oh!

talex5 commented May 11, 2015

Uh oh!

samoht commented May 12, 2015

Uh oh!

avsm commented May 12, 2015

Uh oh!

hannesm commented May 12, 2015

Uh oh!

hannesm commented May 12, 2015

Uh oh!

pqwy commented May 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!