Conversation
|
Any progress on reviewing/merging this patch? |
The include path has changed: we need to include $pkg_ctypes, not
$pkg_ctypes/.. (but I kept the old one for backwards compatibility
for now). The error was:
xen/native/nocrypto_generated_stubs.c:3:37: fatal error:
ctypes_cstubs_internals.h: No such file or directory
#include "ctypes_cstubs_internals.h"
I also had to add an explicit type for a key to fix this error:
Error: The implementation (obtained by packing)
does not match the interface src/nocrypto.mli:
...
In module Cipher_block.DES.Raw:
Values do not match:
val encrypt_block :
key:Unsigned.ulong Static.ptr -> Cstruct.t -> Cstruct.t ->
unit
is not included in
val encrypt_block : key:ekey -> Cstruct.t -> Cstruct.t ->
unit
The trunk version of ctypes's ocamlfind version is only 0.3. Rely on the opam version instead.
|
Ping...any progress on reviewing/merging this patch? |
|
@talex5 -- Sorry for the delay, I've been MIA for various reasons in the past month. Got around to actually testing the setup and it works wonderfully. Not sure if the approach of modifying the build system of any old library you'd want to run on xen, to build the C bits twice, will be tenable further on, but it does its job as a quick fix for the TLS stack flawlessly. Thanks! |
|
Agreed - the long term fix is support for cross-compiling in opam, but it seems that's a long way off. |
|
Agreed on both counts. |
|
Also agreed that cross-compiling is the future, but this is an extremely useful checkpoint.
|
|
Could we have a release with this in it please? |
No description provided.