This repository was archived by the owner on Aug 25, 2022. It is now read-only.
support pin-depends: extend Functoria.package with the optional label…#163
Merged
hannesm merged 1 commit intomirage:masterfrom Nov 16, 2018
Merged
support pin-depends: extend Functoria.package with the optional label…#163hannesm merged 1 commit intomirage:masterfrom
hannesm merged 1 commit intomirage:masterfrom
Conversation
…ed argument `?pin` of type string - if set, the generated opam file includes a `pin-depends: [ name pin ]` line. During `merge` of dependencies, a `pin` wins over version constraints (`min` and `max`).
Member
Author
|
this PR makes my life much easier -- I'm interested in any feedback you may have. if there's no criticism, I'll merge this later today, draft a functoria release, in order to get this within the mirage 3.3.0 release cycle. |
emillon
approved these changes
Nov 16, 2018
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 16, 2018
CHANGES: * compute all transitive opam dependencies for info (mirage/functoria#151, by @hannesm) * support pin-depends in generated opam file (mirage/functoria#163, by @hannesm) * use dune as build system (mirage/functoria#158, by @emillon) * use Ptime for time printing (mirage/functoria#160, by @emillon) * inject global arguments into generated header (mirage/functoria#159, by @emillon) * add Functoria_key.add_to_context (mirage/functoria#161, by @emillon) * output opam2 files (mirage/functoria#157, by @hannesm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed argument
?pinof type string - if set, the generated opam file includes apin-depends: [ name pin ]line. Duringmergeof dependencies, apinwinsover version constraints (
minandmax).This allows us to properly specify development packages as dependencies, such as:
package ~pin:"git+https://github.com/roburio/udns.git" "udns".addresses mirage/mirage#499