Skip to content
This repository was archived by the owner on Aug 25, 2022. It is now read-only.

Inject global arguments into generated_header#159

Merged
samoht merged 1 commit intomirage:masterfrom
emillon:reproducible-generated-header
Oct 4, 2018
Merged

Inject global arguments into generated_header#159
samoht merged 1 commit intomirage:masterfrom
emillon:reproducible-generated-header

Conversation

@emillon
Copy link
Copy Markdown
Contributor

@emillon emillon commented Oct 4, 2018

This has two advantages: first, code that uses this function can now be tested. This could also be extended so that it supports SOURCE_DATE_EPOCH for reproducible builds.

This has two advantages: first, code that uses this function can now be
tested. This could also be extended so that it supports SOURCE_DATE_EPOCH.
@samoht samoht merged commit b481048 into mirage:master Oct 4, 2018
module Codegen: sig

val generated_header: unit -> string
val generated_header: ?argv:string array -> ?time:float -> unit -> string
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'd prefer Ptime.t here.

@emillon emillon deleted the reproducible-generated-header branch October 6, 2018 12:02
hannesm added a commit to hannesm/opam-repository that referenced this pull request Nov 16, 2018
CHANGES:

* compute all transitive opam dependencies for info (mirage/functoria#151, by @hannesm)
* support pin-depends in generated opam file (mirage/functoria#163, by @hannesm)
* use dune as build system (mirage/functoria#158, by @emillon)
* use Ptime for time printing (mirage/functoria#160, by @emillon)
* inject global arguments into generated header (mirage/functoria#159, by @emillon)
* add Functoria_key.add_to_context (mirage/functoria#161, by @emillon)
* output opam2 files (mirage/functoria#157, by @hannesm)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants