Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

Fix: Handle regression caused by gorilla mux v1.7.0#7595

Merged
nitisht merged 1 commit intominio:masterfrom
kannappanr:mux
Apr 29, 2019
Merged

Fix: Handle regression caused by gorilla mux v1.7.0#7595
nitisht merged 1 commit intominio:masterfrom
kannappanr:mux

Conversation

@kannappanr
Copy link
Contributor

@kannappanr kannappanr commented Apr 29, 2019

Description

gorilla/mux#383 broke the compatibility with the existing code.
This PR handles that scenario.

Fixes #7577

Motivation and Context

Issue #7577

Regression

Yes, #7302

How Has This Been Tested?

Tested with repro steps given in #7577

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@kannappanr
Fix: Handle regression caused by gorilla mux v1.7.0
6805bbc 
gorilla/mux#383 broke the compatibility with the existing code.
This PR handles that scenario.
@minio-ops
Copy link

minio-ops commented Apr 29, 2019

Mint Automation

Test Result
mint-xl.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-nas.sh ✔️
mint-compression-xl.sh ❌ more...
mint-large-bucket.sh ❌ more...
mint-compression-dist-xl.sh ❌ more...
mint-fs.sh ❌ more...

7595-6805bbc/mint-compression-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.57:31500
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 669488f543b7:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 0 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... FAILED in 1 seconds
{
  "name": "aws-sdk-php",
  "function": "listObjects ( array $params = [] )",
  "args": {
    "Bucket": "aws-sdk-php-5cc6873bb710e",
    "Object": "obj1"
  },
  "duration": "449",
  "status": "FAIL",
  "error": "Error executing \"CopyObject\" on \"http://72.28.97.57:31500/aws-sdk-php-5cc6873bb710e/obj1-copy-0\"; AWS HTTP error: Server error: `PUT http://72.28.97.57:31500/aws-sdk-php-5cc6873bb710e/obj1-copy-0` resulted in a `503 Service Unavailable` response:\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to re (truncated...)\n XMinioReadQuorum (server): Multiple disk failures, unable to reconstruct data. - <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to reconstruct data.</Message><Key>obj1-copy-0</Key><BucketName>aws-sdk-php-5cc6873bb710e</BucketName><Resource>/aws-sdk-php-5cc6873bb710e/obj1-copy-0</Resource><RequestId>1599D9CCE32EC122</RequestId><HostId>7fbb84c2-4a1a-4158-9b31-263aa4d56047</HostId></Error>"
}

Executed 2 out of 14 tests successfully.

7595-6805bbc/mint-fs.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.52:30475
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp bb1dce040e27:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 0 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-p3x1eplh04zpiw",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 347,
  "error": "RequestError: send request failed\ncaused by: Put http://72.28.97.52:30475/aws-sdk-go-test-p3x1eplh04zpiw: dial tcp 72.28.97.52:30475: connect: connection refused",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

7595-6805bbc/mint-compression-dist-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.53:32333
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp e262b16905f0:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 0 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... FAILED in 1 seconds
{
  "name": "aws-sdk-php",
  "function": "listObjects ( array $params = [] )",
  "args": {
    "Bucket": "aws-sdk-php-5cc6873cb303d",
    "Object": "obj1"
  },
  "duration": "272",
  "status": "FAIL",
  "error": "Error executing \"CopyObject\" on \"http://72.28.97.53:32333/aws-sdk-php-5cc6873cb303d/obj1-copy-0\"; AWS HTTP error: Server error: `PUT http://72.28.97.53:32333/aws-sdk-php-5cc6873cb303d/obj1-copy-0` resulted in a `503 Service Unavailable` response:\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to re (truncated...)\n XMinioReadQuorum (server): Multiple disk failures, unable to reconstruct data. - <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to reconstruct data.</Message><Key>obj1-copy-0</Key><BucketName>aws-sdk-php-5cc6873cb303d</BucketName><Resource>/aws-sdk-php-5cc6873cb303d/obj1-copy-0</Resource><RequestId>1599D9CD14B3FF36</RequestId><HostId>e427be07-339b-4049-9d10-67d6cfa5d641</HostId></Error>"
}

Executed 2 out of 14 tests successfully.

7595-6805bbc/mint-large-bucket.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.60:30926
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 870788dc12cb:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 4 minutes and 30 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-3216bxnf50cnbx",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 270059,
  "error": "XMinioServerNotInitialized: Server not initialized, please try again.\n\tstatus code: 503, request id: 1599DA0B9E0D34D6, host id: ",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

@codecov
Copy link

codecov bot commented Apr 29, 2019 •
edited
Loading

Codecov Report

Merging #7595 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7595      +/-   ##
==========================================
- Coverage   47.36%   47.36%   -0.01%     
==========================================
  Files         293      293              
  Lines       46775    46780       +5     
==========================================
+ Hits        22157    22158       +1     
- Misses      22564    22568       +4     
  Partials     2054     2054
Impacted Files Coverage Δ
cmd/api-router.go 100% <100%> (ø) ⬆️
cmd/retry.go 82.14% <0%> (-5.36%) ⬇️
pkg/certs/certs.go 54.63% <0%> (-4.13%) ⬇️
cmd/bitrot-streaming.go 79.43% <0%> (-3.74%) ⬇️
cmd/fs-v1.go 62.18% <0%> (+0.37%) ⬆️
cmd/posix.go 62.88% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091b9b6...6805bbc. Read the comment docs.

poornas
poornas approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 7810125 into minio:master Apr 29, 2019
kannappanr added a commit to kannappanr/minio that referenced this pull request May 7, 2019
@kannappanr
Fix: Handle regression caused by gorilla mux v1.7.0
b9e890f 
PR minio#7595 fixed part of the regression, but did not handle the
scenario, where in docker, the internal port is different from
the port on the host.

This PR modifies the regular expression such that all the
scenarios are handled.

Fixes minio#7619
@kannappanr kannappanr mentioned this pull request May 7, 2019
Merged
9 tasks
harshavardhana pushed a commit that referenced this pull request May 7, 2019
@kannappanr @harshavardhana
Fix: Handle regression caused by gorilla mux v1.7.0 (#7625)
c422f7f 
PR #7595 fixed part of the regression, but did not handle the
scenario, where in docker, the internal port is different from
the port on the host.

This PR modifies the regular expression such that all the
scenarios are handled.

Fixes #7619
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas poornas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bucket not resolved when using MINIO_DOMAIN

5 participants

@kannappanr @minio-ops @harshavardhana @poornas @nitisht