This repository was archived by the owner on Feb 13, 2026. It is now read-only.
Fix: Handle regression caused by gorilla mux v1.7.0#7625
Merged
harshavardhana merged 1 commit intominio:masterfrom May 7, 2019
Merged
Fix: Handle regression caused by gorilla mux v1.7.0#7625harshavardhana merged 1 commit intominio:masterfrom
harshavardhana merged 1 commit intominio:masterfrom
Conversation
PR minio#7595 fixed part of the regression, but did not handle the scenario, where in docker, the internal port is different from the port on the host. This PR modifies the regular expression such that all the scenarios are handled. Fixes minio#7619
harshavardhana
approved these changes
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #7625 +/- ##
==========================================
- Coverage 47.31% 47.29% -0.03%
==========================================
Files 293 293
Lines 46726 46722 -4
==========================================
- Hits 22109 22097 -12
- Misses 22567 22572 +5
- Partials 2050 2053 +3
Continue to review full report at Codecov.
|
Mint Automation
|
krishnasrinivas
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #7595 fixed part of the regression, but did not handle the
scenario, where in docker, the internal port is different from
the port on the host.
This PR modifies the regular expression such that all the
scenarios are handled.
Fixes #7619
Motivation and Context
Issues #7577 and #7619
Regression
Yes
How Has This Been Tested?
with steps mentioned in #7577
Types of changes
Checklist:
mintPR # here: )