Skip to content

CI: update docker/login-action across the repo#1631

Merged
gilescope merged 2 commits into
mainfrom
chore-gha-updates
Jun 3, 2026
Merged

CI: update docker/login-action across the repo#1631
gilescope merged 2 commits into
mainfrom
chore-gha-updates

Conversation

@LGLO

@LGLO LGLO commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Overview

There is a warning:

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: docker/login-action@184bdaa. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
@LGLO LGLO requested a review from a team as a code owner June 3, 2026 07:15
Signed-off-by: Lech Głowiak <LGLO@users.noreply.github.com>
@gilescope gilescope added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 2a4f35d Jun 3, 2026
37 checks passed
@gilescope gilescope deleted the chore-gha-updates branch June 3, 2026 08:08
gilescope added a commit that referenced this pull request Jun 3, 2026
With #1629 (per-runner host-port isolation) reverted, re-apply our approach on
the clean base:
  - action.yml: run the whole premerge surface via earthly -P +local-env-ci
    (stack -> finality -> e2e -> toolkit) inside nested dockerd; keeps #1631's
    docker/login-action v4.2.0 bump.
  - continuous-integration.yml: drop the local-environment-tests-self-hosted
    concurrency group (netns isolation removes host-port collisions). Preserves
    #1631 (login-action) and #1604 (Ledger9 toolkit-js step comments).

Net vs main: the two approaches to shielded-sre#281 are mutually exclusive;
this branch chooses nested-dockerd netns isolation over per-runner port blocks.

Assisted-by: Claude:claude-opus-4-8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants