Ledger9 with no migration by LGLO · Pull Request #1604 · midnightntwrk/midnight-node

LGLO · 2026-05-28T12:31:09Z

Overview

Add Ledger9 alpha.1 support.
At this point it allows new chain to start in the local-environment.

🗹 TODO before merging

Ready

📌 Submission Checklist

All commits are signed off (git commit -s) for the DCO
Changes are backward-compatible (or flagged if breaking)
Pull request description explains why the change is needed
Self-reviewed the diff
I have included a change file, or skipped for this reason:
If the changes introduce a new feature, I have bumped the node minor version
Update documentation (if relevant)
Updated AGENTS.md if build commands, architecture, or workflows changed
No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

Additional tests are provided (if possible)

🔱 Fork Strategy

Node Runtime Update
Node Client Update
Other:
N/A

Links

#1579

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36decc6087

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78219b6fe3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a8f6bbab7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7476dabe0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28e2ecf97c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a73c339b6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b69aabd027

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f667fb3fa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ozgb

LGTM, nice work!

Some comments to ensure follow-up work doesn't get lost

ozgb · 2026-06-02T10:24:00Z

Let's bump the toolkit version to 2.0.0 too

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

With #1629 (per-runner host-port isolation) reverted, re-apply our approach on the clean base: - action.yml: run the whole premerge surface via earthly -P +local-env-ci (stack -> finality -> e2e -> toolkit) inside nested dockerd; keeps #1631's docker/login-action v4.2.0 bump. - continuous-integration.yml: drop the local-environment-tests-self-hosted concurrency group (netns isolation removes host-port collisions). Preserves #1631 (login-action) and #1604 (Ledger9 toolkit-js step comments). Net vs main: the two approaches to shielded-sre#281 are mutually exclusive; this branch chooses nested-dockerd netns isolation over per-runner port blocks. Assisted-by: Claude:claude-opus-4-8

The GitHub-UI merge of main into this branch brought in ledger_9.rs (PR #1604) without declaring `pub mod output_spec;`, leaving single_tx and batch_single_tx unable to resolve `super::output_spec` when compiled under the ledger_9 variant. Matches what ledger_7 and ledger_8 already do. Fixes the +check-rust and +check-feature-unification CI failures on PR #1560. Assisted-by: Claude:claude-4.7-opus Signed-off-by: chrispalaskas <chris.palaskas@gmail.com>

LGLO requested a review from a team as a code owner May 28, 2026 12:31

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread util/toolkit/src/tx_generator/builder/mod.rs

Comment thread ledger/src/lib.rs

LGLO commented May 28, 2026

View reviewed changes

Comment thread res/dev/cnight-config.json

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread ledger/src/host_api/ledger_8.rs

Comment thread runtime/src/lib.rs Outdated

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread util/toolkit/src/tx_generator/builder/mod.rs Outdated

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread util/toolkit/src/tx_generator/builder/mod.rs

ozgb reviewed May 29, 2026

View reviewed changes

Comment thread res/govnet/ledger-parameters-config.json

Comment thread Earthfile Outdated

cosmir17 mentioned this pull request May 29, 2026

feat: support ledger v9 and node v2.0 midnightntwrk/midnight-indexer#1193

Merged

Klapeyron mentioned this pull request Jun 1, 2026

chore: migrated to ledger-9.0.1.0-alpha.1 #1563

Closed

15 tasks

ozgb linked an issue Jun 1, 2026 that may be closed by this pull request

Add support for ECDSA signatures #1542

Open

ozgb mentioned this pull request Jun 1, 2026

Update compact.js to support Ledger 9 midnightntwrk/midnight-sdk#158

Open

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread ledger/helpers/src/fork/fork_aware_context.rs Outdated

Comment thread util/toolkit/src/tx_generator/builder/mod.rs

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread runtime/src/lib.rs

LGLO force-pushed the ledger-9-no-migration branch from dde1d4b to f8616de Compare June 2, 2026 07:38

Klapeyron and others added 4 commits June 2, 2026 10:08

chore: migrated to ledger-9.0.1.0-alpha.1

5bb4b6c

Signed-off-by: Tomasz Bartos <tomasz.bartos@shielded.io>

Migration to ledger 9 cont.

9d6775a

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

Ignore tests that require intent files in Ledger v9 format

5c9ce33

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

Rebuild 'devnet' chain-spec and undeployed/test blocks and contracts

b69aabd

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

LGLO force-pushed the ledger-9-no-migration branch from f8616de to b69aabd Compare June 2, 2026 08:20

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread util/toolkit/src/tx_generator/builder/mod.rs

rsporny reviewed Jun 2, 2026

View reviewed changes

Comment thread res/qanet/cnight-config.json

Revert QANet, Govnet, Perfnet, Preview, and Mainnet 'res' changes.

6f667fb

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

LGLO force-pushed the ledger-9-no-migration branch from 3e85876 to 6f667fb Compare June 2, 2026 09:30

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread node/src/chain_spec/mod.rs

ozgb previously approved these changes Jun 2, 2026

View reviewed changes

gilescope reviewed Jun 2, 2026

View reviewed changes

Comment thread runtime/src/lib.rs Outdated

LGLO dismissed ozgb’s stale review via 3103020 June 2, 2026 11:05

gilescope reviewed Jun 2, 2026

View reviewed changes

Comment thread ledger/helpers/src/fork/fork_aware_context.rs Outdated

Apply review comments

895755a

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

LGLO force-pushed the ledger-9-no-migration branch from 3103020 to 895755a Compare June 2, 2026 11:08

Update RuntimeVersion::transaction_version to 4

0cb4297

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

gilescope reviewed Jun 2, 2026

View reviewed changes

Comment thread runtime/Cargo.toml

gilescope previously approved these changes Jun 2, 2026

View reviewed changes

Update metadata and fix a comment

a2d0614

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

LGLO dismissed gilescope’s stale review via a2d0614 June 2, 2026 12:18

LGLO added 2 commits June 2, 2026 15:38

Merge branch 'main' into ledger-9-no-migration

d4baf3e

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

Merge branch 'main' into ledger-9-no-migration

c2bcfa4

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

LGLO enabled auto-merge June 2, 2026 14:11

gilescope previously approved these changes Jun 2, 2026

View reviewed changes

Comment out jobs, continue-on-error is not enough

db3f327

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

LGLO dismissed gilescope’s stale review via db3f327 June 2, 2026 15:21

LGLO and others added 3 commits June 3, 2026 07:30

Merge branch 'main' into ledger-9-no-migration

eb05313

Ignore some E2E test in a way job is still present

b1f76b1

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

Merge branch 'main' into ledger-9-no-migration

45c4b6c

Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>

Klapeyron approved these changes Jun 3, 2026

View reviewed changes

LGLO added this pull request to the merge queue Jun 3, 2026

Merged via the queue into main with commit 01b51ab Jun 3, 2026
37 checks passed

LGLO deleted the ledger-9-no-migration branch June 3, 2026 06:54

ozgb mentioned this pull request Jun 3, 2026

Add support for ECDSA signatures #1542

Open

Conversation

LGLO commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

🗹 TODO before merging

📌 Submission Checklist

🧪 Testing Evidence

🔱 Fork Strategy

Links

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ozgb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozgb commented Jun 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LGLO commented May 28, 2026 •

edited

Loading