Update release configuration -use flit for pulishing#738
Conversation
andrueastman
left a comment
There was a problem hiding this comment.
Does this mean we can drop the version entry in the toml file as well?
In my view, Nope - the workflow is triggered when there is a new change, with a tag starting with v, we still need to ensure the toml entry for version matches the pushed tag |
|
I ask because the issue was created because the abstraction library does not have a version in the toml file. https://github.com/microsoft/kiota-abstractions-python/blob/main/pyproject.toml So, the change was to make it easier by only having to update the version in one place(which is at https://github.com/microsoftgraph/msgraph-sdk-python/blob/main/msgraph/_version.py ) |
Made changes to update version in toml based on the tag |
Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com>
….com:microsoftgraph/msgraph-sdk-python into shem/update_release_configurations_use_flint
samwelkanda
left a comment
There was a problem hiding this comment.
Since this issue was created with the goal of standardization, do we also plan to update the core libraries to use this format as well?
|
I believe so, separate issue for core lib exists at microsoftgraph/msgraph-sdk-python-core#573 and is already assigned to @shemogumbe |
|
getting there, I made my comments on the beta PR for some reason this time around... |
|
again @shemogumbe please see the latest recommended changes there microsoftgraph/msgraph-beta-sdk-python#424, and once the updates are done in beta, replicate here. |
….com:microsoftgraph/msgraph-sdk-python into shem/update_release_configurations_use_flint
Closes microsoftgraph/msgraph-beta-sdk-python#412
-Update publishing tool from python build to flit.