Skip to content

Release M.G.C 1.19.0 -FileUpload, Batch+Request Builders+serializer, Chaos #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrueastman merged 7 commits into from
Dec 11, 2019
Merged

Release M.G.C 1.19.0 -FileUpload, Batch+Request Builders+serializer, Chaos #69

andrueastman merged 7 commits into from
Dec 11, 2019

Conversation

@MIchaelMainer
Copy link
Collaborator

@MIchaelMainer MIchaelMainer commented Dec 10, 2019 •
edited
Loading

  • Adds request builders for the batch endpoint to the client
  • Resolves HttpProvider re-write to fully support GraphClientFactory. #27. Enhances GraphClientFactory compatibility by enabling GraphServiceClient creation by passing in a custom HttpClient - BatchRequestStep enhancements: added overloads to add BatchRequestStep using BaseRequest and HttpRequestMessage.
  • Adds ChaosHandler for testing.
  • HTTP pipeline updates overwrite existing inner handlers.
  • BatchRequestContent enhancements to enable deserialization to a given type
  • Updates to fix and use common serializer for batch content
  • Adds FileUploadTask to provide support for file/attachement upload

andrueastman and others added 7 commits October 17, 2019 09:46
@andrueastman
Adds request builder for the batch endpoint to base client (#48)
a2a7e2b 
- Adds tests to validate
@andrueastman
BatchRequestStep enhancements (#47)
3e8f7d7 
* BatchRequestStep enhancements

- Adds overload to add steps using HttpRequestMessage
- Adds overload to add steps using IBaseRequest
- Adds tests to validate
- Adds checks to ensure steps do not exceed max value set for graph

* Makes new overloads to return void and updates relevant tests
@darrelmiller @MIchaelMainer
Update pipeline building overwrite existing inner handlers (#53)
ada4500
@darrelmiller @MIchaelMainer
Added ChaosHandler (#55)
34764a5
@andrueastman
Batch Request Enhancements (#56)
3c24714 
- Return ids on creating step without providing one
- Allow deseriaizing of requests to known type on geting response from ID
- Added tests
@andrueastman
Fix for deserialization in Batch requests and responses (#66)
7bf1f20
@andrueastman
FileUpload Task (#65)
bc4c887 
* FileUpload task with DriveItem and FileAttachement support

* Update csproj

* Deserialize stream rather than dumping into string to improve performance

- make uplaodsliceRequest and get uploadSlices private

* Add test to capure 200 drive response

- Makes sure stream used for deserialization is disposed.

* PR Review Feedback 

- Fix typos
- Add comments to source
- Make UploadResponseHandler and UploadSliceRequest intenal classes
- Remove unnecessary options from upload requests

* Check if uploadSession is still valid before trying to delete it.

* Renames UploadSessionInfo to UploadSession and UploadSessionInfoRequest to UploadSessionRequest
@MIchaelMainer MIchaelMainer added this to the 1.19.0 milestone Dec 10, 2019
@MIchaelMainer MIchaelMainer changed the title Release M.G.C 1.19.0 Release M.G.C 1.19.0 -FileUpload, Batch+Request Builders+serializer, Chaos Dec 10, 2019
@MIchaelMainer
Copy link
Collaborator Author

MIchaelMainer commented Dec 10, 2019

Complete microsoftgraph/msgraph-sdk-dotnet#593 once this PR is done and the 1.19.0 release is on NuGet.

andrueastman
andrueastman approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@andrueastman andrueastman merged commit f84457d into master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

1 more reviewer

@andrueastman andrueastman andrueastman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@MIchaelMainer @andrueastman @darrelmiller