Update pipeline building. #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIchaelMainer
previously approved these changes
Oct 21, 2019
Collaborator
MIchaelMainer
left a comment
There was a problem hiding this comment.
Looks good. It would be helpful that we document this behavior on line 79 to indicate that any inner handler reference will be overwritten.
MIchaelMainer
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the GraphClientFactory builds a middleware pipeline, it checks to see if a handler already has InnerHandler set. If it is, it throws an exception.
This causes a problem for handlers that set a finalhandler by default in their constructor. This is a fairly common pattern.
This PR changes the behaviour to simply overwrite any existing InnerHandler. The idea is that if a developer provides 4 handlers explicitly in the array, then the pipeline should contain exactly just those 4 handlers plus the finalhandler.