-
Notifications
You must be signed in to change notification settings - Fork 62
FileUpload Task #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
FileUpload Task #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there a reason why we want to expose GetUploadSliceRequests() ? I don't see an advantage of exposing this. /cc @MIchaelMainer |
…ance - make uplaodsliceRequest and get uploadSlices private
- Makes sure stream used for deserialization is disposed.
Contributor
Author
|
I have updated the PR to :
|
MIchaelMainer
requested changes
Dec 4, 2019
Collaborator
MIchaelMainer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the late review.
- Fix typos - Add comments to source - Make UploadResponseHandler and UploadSliceRequest intenal classes - Remove unnecessary options from upload requests
…st to UploadSessionRequest
MIchaelMainer
approved these changes
Dec 4, 2019
peombwa
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes microsoftgraph/msgraph-sdk-dotnet#467
Changes proposed in the pull request
Essentially, one may perform a large upload by following the steps below.
Using the task
FileAttachment support
The same steps can be followed for the FileAttachement upload by first creating an upload session and handing it over to the task as illustrated earlier.
However, the service only returns location URI which can be read off from the result object as follows. follows in step 4 as follows.
Other links
Notes
This PR can also be tested using the sample at the repository in the following link. It uses this PR as a git submodule.
https://github.com/andrueastman/UploadTest