Sync dev changes with feature/3.0 #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 23, 2022 12:59
…Bugs Fix for BatchResponseContent.GetResponseByIdAsync nullref and incorrect content header for non json response
Always ConfiguteAwait false on awaited tasks
baywet
approved these changes
Feb 23, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
the configure await changes might need to get reflected in the kiota libs as well.
| /// Gets the <see cref="IRequestAdapter"/> for sending requests. | ||
| /// </summary> | ||
| protected internal IRequestAdapter RequestAdapter { get; set; } | ||
| protected internal virtual IRequestAdapter RequestAdapter { get; set; } |
Member
There was a problem hiding this comment.
is the only point of this class to expose the batch property to the fluent API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs relevant changes on the dev branch with the feature/3.0 branch,
Changes include:
RequestAdaptermember inBaseClientvirtual allow potential overriding.Microsoft Reviewers: Open in CodeFlow