Skip to content

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Feb 16, 2022

This PR closes #368 and closes #22

Changes include:

  • Returning default in the event the HttpResponseMessage message is non existent when trying to deserialize a payload from batch
  • Ensure all headers are passed to the HttpContent of httpResponseMessage as this resulted in incorrect Content-Type headers
  • Update tests to cover these scenraios
Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman marked this pull request as ready for review February 16, 2022 07:32
@andrueastman andrueastman requested a review from baywet February 16, 2022 07:32
@andrueastman andrueastman self-assigned this Feb 16, 2022
@andrueastman andrueastman merged commit ce2f2f0 into dev Feb 16, 2022
@andrueastman andrueastman deleted the andrueastman/BatchContentBugs branch February 16, 2022 13:26
@andrueastman andrueastman mentioned this pull request Feb 17, 2022
andrueastman pushed a commit that referenced this pull request Feb 23, 2022
…Bugs

Fix for BatchResponseContent.GetResponseByIdAsync nullref and incorrect content header for non json response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BatchResponseContent.GetResponseByIdAsync<T> throws nullref exception if response was not found Add support for non-json bodies in Batch content

3 participants