Always ConfiguteAwait false on awaited tasks #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andrueastman
approved these changes
Jan 28, 2022
Contributor
|
Thanks for this @mvarblow |
Merged
andrueastman
pushed a commit
that referenced
this pull request
Feb 23, 2022
Always ConfiguteAwait false on awaited tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Some awaited tasks included ConfigureAwait(false) but many did not. One of these continuations that was missing the ConfigureAwait(false) seemed to be causing deadlocks in our use of the Graph API (when acquiring a token). This pull request adds ConfigureAwait(false) to all awaited tasks.
Other links
#267
#188
Microsoft Reviewers: Open in CodeFlow