Conversation
ole32.dll in Windows crates for compatibilityole32.dll in windows-core crate for compatibility
ole32.dll in windows-core crate for compatibilityole32.dll dependency from windows-core crate for compatibility
Collaborator
|
Spot checked Windows 10 22H2 and all those functions were present in combase.dll, so looks safe so far. |
Collaborator
Author
|
Thanks, I also manually checked |
will-j-wright
added a commit
to microsoft/openvmm
that referenced
this pull request
Sep 8, 2025
For a closed-source change, we need the newest version of the windows crates, specifically microsoft/windows-rs#3724 and microsoft/windows-rs#3743.
gurasinghMS
pushed a commit
to gurasinghMS/openvmm
that referenced
this pull request
Sep 9, 2025
For a closed-source change, we need the newest version of the windows crates, specifically microsoft/windows-rs#3724 and microsoft/windows-rs#3743.
Contributor
|
This broke Windows 7 support, which doesn't have combase.dll. Would it be possible to reintroduce the |
Collaborator
|
Hey @roblabla, we don't see sufficient value in adding additional complexity here to support Windows 7 at this time. (Sorry!) Perhaps you can include a small forwarder with your target? lib.rs: macro_rules! stub {
($name:ident) => {
#[allow(non_snake_case)]
#[unsafe(export_name = stringify!($name))]
pub extern "C" fn $name() {
unreachable!()
}
};
($($name:ident),+ $(,)?) => {
$(stub!($name);)+
};
}
stub!(
CoCreateFreeThreadedMarshaler,
CoIncrementMTAUsage,
CoTaskMemAlloc,
CoTaskMemFree,
RoGetAgileReference,
);build.rs: fn main() {
println!("cargo::rustc-link-arg=/DEF:module.def");
}module.def: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some editions of Windows, mostly used internally by Microsoft, don't include
ole32.dll. This update attempts to remap a handful of functions that are particularly problematic. This PR should validate that this is viable for now on Windows 11 and we just need to manually test on Windows 10 to make sure this can support the Rust toolchain in general which still targets Windows 10.