Skip to content

Update windows-* crates#1972

Merged
will-j-wright merged 2 commits intomicrosoft:mainfrom
will-j-wright:update-windows-crates
Sep 8, 2025
Merged

Update windows-* crates#1972
will-j-wright merged 2 commits intomicrosoft:mainfrom
will-j-wright:update-windows-crates

Conversation

@will-j-wright
Copy link
Contributor

@will-j-wright will-j-wright commented Sep 5, 2025 •
edited
Loading

For a closed-source change, we need the newest version of the windows crates, specifically microsoft/windows-rs#3724 and microsoft/windows-rs#3743.

We also needed to update socket2, which was using a very old windows-sys version and was causing some issues with the tests.

Copilot AI review requested due to automatic review settings September 5, 2025 20:00
@will-j-wright will-j-wright requested review from a team as code owners September 5, 2025 20:00
Copilot AI reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Windows crates to their latest versions to incorporate specific upstream changes needed for a closed-source feature. The updates include windows crate from 0.61 to 0.62 and windows-sys crate from 0.60 to 0.61.

  • Updates windows crate from version 0.61 to 0.62
  • Updates windows-sys crate from version 0.60 to 0.61
  • Incorporates specific upstream PRs #3724 and #3743 from the windows-rs repository

@will-j-wright will-j-wright changed the title Update windows crates Update windows-* crates Sep 5, 2025
@smmalis37
Copy link
Contributor

smmalis37 commented Sep 6, 2025

It looks like this PR contains updates to a lot of other crates in the lock file. Can those be undone?

@smalis-msft
Copy link
Contributor

smalis-msft commented Sep 8, 2025

Some of these crates, like ctrlc and zerocopy, should have nothing to do with the windows crates. They'll need to be reverted. Are you running an unrestricted cargo update? That'll update every crate, and could result in this. Instead you should run just a cargo update -p windows-foo or similar.

@will-j-wright
Copy link
Contributor Author

will-j-wright commented Sep 8, 2025

Yeah, my bad. Didn't realize that cargo update updates everything :)

smalis-msft
smalis-msft previously approved these changes Sep 8, 2025
View reviewed changes
@will-j-wright will-j-wright enabled auto-merge (squash) September 8, 2025 18:52
@will-j-wright will-j-wright merged commit a44b417 into microsoft:main Sep 8, 2025
29 checks passed
@smalis-msft
Copy link
Contributor

smalis-msft commented Sep 9, 2025

Cool, glad the fix was straightforward

gurasinghMS pushed a commit to gurasinghMS/openvmm that referenced this pull request Sep 9, 2025
@will-j-wright @gurasinghMS
Update windows-* crates (microsoft#1972)
70a3414 
For a closed-source change, we need the newest version of the windows
crates, specifically microsoft/windows-rs#3724
and microsoft/windows-rs#3743.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@benhillis benhillis benhillis approved these changes

@smalis-msft smalis-msft smalis-msft left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@will-j-wright @smmalis37 @smalis-msft @benhillis