Implement FontStyle.Strikethrough#159
Merged
Conversation
Member
|
I think we should also adjust vscode-textmate/src/grammar.ts Line 23 in d87b3d5 |
Author
|
Alright will we be removing |
Member
|
No, |
Author
|
Oh right tests will need updating too |
Member
|
Yes, looks like there's another |
Author
|
Huh it's passing nice |
Member
|
Nice! Thank you! I will look into reviving microsoft/vscode#131428 |
sebthom
added a commit
to sebthom/tm4e
that referenced
this pull request
Apr 28, 2022
sebthom
added a commit
to eclipse-tm4e/tm4e
that referenced
this pull request
May 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing tests for this might make us all a little
cross(had to!)Closes #158.