Add Textmate's strikethrough fontStyle#131428
Conversation
strikethrough fontStyle
|
@alexdima h e l p (maybe in september or october of course) |
alexdima
left a comment
There was a problem hiding this comment.
Unfortunately this is incorrect.
Such a change needs to begin in the project vscode-textmate. The bit encoding format for tokens is defined in that project at: https://github.com/microsoft/vscode-textmate/blob/a53ae3c12bef5499a7dc548b3058ee64bfcbd222/src/main.ts#L201-L233
Once that project has a new token bit encoding format, it needs to be published with a new major version (since this is a breaking change) and then adopted in VS Code.
Also, the enums are powers of 2 because they represent bits, so FontStyle.Strikethrough would be 8. But for it to be 8, then all the other information bits need to be shifted by 1.
|
Alright, I'll be closing this and letting Microsoft get to this if and when #43504 goes through |
This PR fixes #78358. Related to #43504, based on the corresponding feature in Textmate: