Skip to content

Add Textmate's strikethrough fontStyle#131428

Closed
ghost wants to merge 3 commits intomainfrom
unknown repository
Closed

Add Textmate's strikethrough fontStyle#131428
ghost wants to merge 3 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 23, 2021

@ghost ghost changed the title Add strikethrough fontStyle to Textmate Add Textmate's strikethrough fontStyle Aug 23, 2021
@ghost ghost changed the title Add Textmate's strikethrough fontStyle Add Textmate's strikethrough fontStyle Aug 23, 2021
@ghost
Copy link
Author

ghost commented Aug 23, 2021

@alexdima h e l p (maybe in september or october of course)

Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this is incorrect.

Such a change needs to begin in the project vscode-textmate. The bit encoding format for tokens is defined in that project at: https://github.com/microsoft/vscode-textmate/blob/a53ae3c12bef5499a7dc548b3058ee64bfcbd222/src/main.ts#L201-L233

Once that project has a new token bit encoding format, it needs to be published with a new major version (since this is a breaking change) and then adopted in VS Code.

Also, the enums are powers of 2 because they represent bits, so FontStyle.Strikethrough would be 8. But for it to be 8, then all the other information bits need to be shifted by 1.

@ghost
Copy link
Author

ghost commented Aug 25, 2021

Alright, I'll be closing this and letting Microsoft get to this if and when #43504 goes through

@ghost ghost closed this Aug 25, 2021
@ghost ghost deleted the feature-tokenization-strikethrough branch August 25, 2021 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
@alexdima
Copy link
Member

@sndst00m I'm having trouble reopening this PR because the original repository has been deleted. I have adopted the latest vscode-textmate in #139361 . Could you please recreate this PR?

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support fontStyle "strikethrough" about theme

1 participant