Skip to content

Adopt vscode-textmate@6.0.0#139361

Merged
alexdima merged 1 commit intomainfrom
alex/vscode-textmate-6.0.0
Dec 17, 2021
Merged

Adopt vscode-textmate@6.0.0#139361
alexdima merged 1 commit intomainfrom
alex/vscode-textmate-6.0.0

Conversation

@alexdima
Copy link
Member

No description provided.

@alexdima alexdima added this to the January 2022 milestone Dec 17, 2021
@alexdima alexdima self-assigned this Dec 17, 2021
@alexdima alexdima merged commit 15f7cad into main Dec 17, 2021
@alexdima alexdima deleted the alex/vscode-textmate-6.0.0 branch December 17, 2021 10:34
@ghost
Copy link

ghost commented Dec 17, 2021

https://github.com/microsoft/vscode/pull/131428.patch and git apply 131428.patch are your friends (with corrections)

@ghost
Copy link

ghost commented Dec 17, 2021

Actually I'll write PR and try fix it

@alexdima
Copy link
Member Author

https://github.com/microsoft/vscode/pull/131428.patch and git apply 131428.patch are your friends (with corrections)
Actually I'll write PR and try fix it

Yes, I could do that and then do git commit --author, which will credit your work correctly in GitHub. But if you create the PR, that would allow our Thank you tool to also pick it up and give you credit in our release notes

@ghost
Copy link

ghost commented Dec 17, 2021

SEMANTIC_USE_STRIKETHROUGH is missing, whats the strat on adding that to TokensStore2.addSemanticTokens?

@ghost

This comment has been minimized.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant