Fix comment layout & use bin as delete icon#4285
Merged
alexr00 merged 8 commits intomicrosoft:mainfrom Dec 19, 2022
Merged
Conversation
46rouser
previously approved these changes
Dec 5, 2022
alexr00
requested changes
Dec 19, 2022
Member
alexr00
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'm seeing an x overlayed over the bin icon:
Other than that, it looks good.
andreamah
approved these changes
Dec 19, 2022
eslamashour1
pushed a commit
to eslamashour1/vscode-pull-request-github
that referenced
this pull request
Dec 31, 2022
* Use bin as delete icon * Don't remove action bar * Fix layout * Revert unrelated format changes * Fix icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #4057