Fixes to comment action bar & use bin as delete icon#4057
Fixes to comment action bar & use bin as delete icon#4057Thomas1664 wants to merge 14 commits intomicrosoft:mainfrom
Conversation
|
I want to align the secondary button on comments to the right as well because the user needs less eye movement to see both buttons. Before:
After:
|
daviddossett
left a comment
There was a problem hiding this comment.
Thanks for the PR! Couple of issues but should be good to go once resolved.
|
Depends on #4066 |
alexr00
left a comment
There was a problem hiding this comment.
I'm seeing a misalignment of the buttons when editing a comment:
Otherwise, it looks good!
What do you mean by misalignment? If you are referring to both buttons now being on the right, this is intentional:
|
|
@Thomas1664 I'm referring to the lack of padding around the buttons in the bottom right corner. They are right up against the comment thread border. |
After:
Normal comment:
|
|
Here's what I'm seeing. The text area is crammed up against the edges, as are the buttons:
The case where a comment is being edited inline is special in that the form actions need different padding rules to fit nicely within their container. I suggest we give this
|
The current delete icon is a cross (
x) but I think that we associate a cross more with close. Therefore, I think the bin icon expresses 'delete' better than a cross.For some reason the hygiene script was not happy with my copyright comment. Because I noticed that other PRs didn't add a copyright when editing icons, I chose to do the same.
I also changed the comment action bar to hiding instead of removing itself if the comment is not hovered. Furthermore, the action bar used to not show on focus. I fixed this bug as well.