[Application QuickStart] [Backend] Restricting DAB local container deployment to Sql Auth#21554
Merged
Merged
Conversation
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21554 +/- ##
==========================================
+ Coverage 72.68% 72.69% +0.01%
==========================================
Files 331 331
Lines 98504 98546 +42
Branches 5465 5470 +5
==========================================
+ Hits 71595 71637 +42
Misses 26909 26909
🚀 New features to boost your workflow:
|
17 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Restricts Schema Designer’s Data API Builder (DAB) local container deployment workflow to SQL Authentication (SqlLogin) connections, since local Docker-based deployment can’t complete interactive/token-based authentication (e.g., Fabric/Azure MFA).
Changes:
- Adds
isDabDeploymentSupportedto Schema Designer webview state and computes it from the connection authentication type. - Disables the Deploy button in the DAB toolbar (with tooltip text) and adds a backend guard in the deployment RPC handler.
- Adds unit tests covering supported/unsupported auth types and the deployment guard behavior, plus new localized string entries.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Adds new user-facing string for the “SQL Auth only” restriction. |
| extensions/mssql/test/unit/schemaDesignerWebviewController.test.ts | Adds unit tests for deployment support detection and guard behavior. |
| extensions/mssql/src/sharedInterfaces/schemaDesigner.ts | Extends Schema Designer state with isDabDeploymentSupported. |
| extensions/mssql/src/schemaDesigner/schemaDesignerWebviewController.ts | Computes support flag and blocks deployment RPC requests when unsupported. |
| extensions/mssql/src/reactviews/pages/SchemaDesigner/dab/dabToolbar.tsx | Disables Deploy button and shows tooltip messaging based on support flag. |
| extensions/mssql/src/reactviews/pages/SchemaDesigner/dab/dabContext.tsx | Plumbs isDabDeploymentSupported from Schema Designer state into DAB context. |
| extensions/mssql/src/reactviews/common/locConstants.ts | Adds webview localization entry for the restriction message. |
| extensions/mssql/src/constants/locConstants.ts | Adds extension-side localization entry for the restriction message (used by controller). |
| extensions/mssql/l10n/bundle.l10n.json | Adds bundle entry for the new localized string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
lewis-sanchez
approved these changes
Mar 11, 2026
aasimkhan30
approved these changes
Mar 11, 2026
manujoseph85
added a commit
that referenced
this pull request
Mar 11, 2026
…ployment to Sql Auth (#21554) * Restricting DAB deployment to Sql Auth connections
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We found an issue where DAB local container deployment does not work for Fabric connections because Fabric only supports Token based auth. Currently, there is no easy way to enable that for local containers.
This pull request introduces a new restriction for local container deployment of the Data API Builder (DAB) feature, ensuring it is only available for SQL Authentication connections.
We will add Azure based container deployments next, and other auth types can be easily supported then with Azure Managed Identity.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines