Skip to content

Port - Restricting DAB local container deployment to Sql Auth#21571

Merged
Benjin merged 1 commit into
release/1.41from
port/majoseph/dab-local-db-restriction
Mar 11, 2026
Merged

Port - Restricting DAB local container deployment to Sql Auth#21571
Benjin merged 1 commit into
release/1.41from
port/majoseph/dab-local-db-restriction

Conversation

@manujoseph85

@manujoseph85 manujoseph85 commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Description

Port for PR: #21554 to resolve #21517

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

…ployment to Sql Auth (#21554)

* Restricting DAB deployment to Sql Auth connections
@github-actions

Copy link
Copy Markdown

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6409 KB 6409 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 7061 KB 7061 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/1.41@4296624). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/1.41   #21571   +/-   ##
===============================================
  Coverage                ?   72.69%           
===============================================
  Files                   ?      331           
  Lines                   ?    98549           
  Branches                ?     5470           
===============================================
  Hits                    ?    71640           
  Misses                  ?    26909           
  Partials                ?        0           
Files with missing lines Coverage Δ
extensions/mssql/src/constants/locConstants.ts 75.95% <100.00%> (ø)
...nsions/mssql/src/reactviews/common/locConstants.ts 25.38% <100.00%> (ø)
.../schemaDesigner/schemaDesignerWebviewController.ts 86.20% <100.00%> (ø)
...sions/mssql/src/sharedInterfaces/schemaDesigner.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin Benjin merged commit 0b696eb into release/1.41 Mar 11, 2026
3 checks passed
@Benjin Benjin deleted the port/majoseph/dab-local-db-restriction branch March 11, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants