Consolidate duplicated UpdateTracker code#273858
Merged
Conversation
b04b32c to
3d66fb9
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the UpdateTracker class to be more generic and reusable by consolidating two similar tracker implementations. The main purpose is to eliminate code duplication and create a single unified tracker that can handle both prompts and agents.
Key changes:
- Consolidates
UpdateTrackerandPromptUpdateTrackerclasses into a single parameterizedUpdateTrackerclass - Standardizes naming conventions across types and methods (e.g.,
onDiDPromptChange→onDidPromptChange) - Removes unused import (
AGENT_LANGUAGE_ID) and fixes a trailing backslash in a comment
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Show resolved
Hide resolved
bpasero
approved these changes
Oct 29, 2025
dmitrivMS
pushed a commit
that referenced
this pull request
Oct 29, 2025
Consolidate duplicated UpdateTracker code in promptsServiceImpl.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateTrackerandPromptUpdateTrackerwere almost identical (after the latter was added in #271187), so this PR combines them together into a single class.