Merged
Conversation
Member
|
I was just trying this, and if I cancel a tool call, I'm stuck with a spinner |
Member
|
LGTM- this fixes https://github.com/microsoft/vscode-copilot/issues/15652, thanks! |
rzhao271
approved these changes
Apr 25, 2025
bhavyaus
pushed a commit
that referenced
this pull request
Apr 27, 2025
* chat: include origin MCP server with tool call confirmation Refs #246287 * chat: add 'see more' to confirmation widget input * tools: adopt new styling for tools from #246287 * tools: add indicator when mcp tool calls fail Fixes #246563 * chat: keep tool widget expansion state on re-render * tweak some margin and sizing
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
Apr 30, 2025
* chat: include origin MCP server with tool call confirmation Refs microsoft#246287 * chat: add 'see more' to confirmation widget input * tools: adopt new styling for tools from microsoft#246287 * tools: add indicator when mcp tool calls fail Fixes microsoft#246563 * chat: keep tool widget expansion state on re-render * tweak some margin and sizing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adopts the suggested improvements and closes #246287
{which is not usefulChatCollapsibleEditorContentPartwhich I think is necessary overall when MCP starts supporting images.25-04-701fa10f-39ee-4b1c-8da8-7a61f7e62c9c.1.mp4