Create AccessibleView, use it for terminal and chat accessibility help menus#184435
Merged
Conversation
rebornix
reviewed
Jun 6, 2023
rebornix
left a comment
Contributor
There was a problem hiding this comment.
I wonder if it makes sense to leverage MultiCommand
vscode/src/vs/editor/browser/editorExtensions.ts
Lines 193 to 194 in d4f29ca
- Single command contribution, each contributor only needs to register a provider other than both the provider and the action contribution
- If users want to change the keybinding, they don't have to change the keybindings for every
*.showAccessibilityHelpViewcommand. - This command can then also be added to the Menu
Current approach doesn't seem to scale.
Collaborator
Author
|
Yes @rebornix i thought the same and was unaware such a thing existed. Thanks! |
Collaborator
Author
|
@rebornix i'll need to defer that to the PR where I convert the editor accessibility help action to use this - currently, what's happening is that is overriding the terminal's action since there's no Edit: got it to work |
Tyriar
previously requested changes
Jun 6, 2023
meganrogge
commented
Jun 7, 2023
Tyriar
previously requested changes
Jun 7, 2023
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Tyriar
previously approved these changes
Jun 8, 2023
connor4312
approved these changes
Jun 8, 2023
cadinsl
pushed a commit
to cadinsl/vscode
that referenced
this pull request
Jun 13, 2023
…View Create `AccessibleView`, use it for terminal and chat accessibility help menus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183363
fixes #179689
Remaining help menu adoption (more complex so in separate PRs):
To do later:
AccessibleView#184612demo.mov