Feat: #132598 Add notification in case of running a translated build on windows and macOS#181191
Conversation
deepak1556
left a comment
There was a problem hiding this comment.
thanks for working on the PR
|
Maybe we can add a button to the VSCode download page in the notification? |
|
@deepak1556 gentle ping, thanks. |
|
@deepak1556 any news on this PR? |
|
Sorry for the silence here, I like the idea of having a download link to the universal build in the notification. Can you make the change, if not I can address it in this PR. |
Added the button, waiting for review. |
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
|
I think this PR is ready. |
|
Yup it should be good to go, waiting for another round of review from @isidorn |
|
Looks great. Thanks for this PR 👏 |
|
For visibility, the current notification looks like 
|
deepak1556
left a comment
There was a problem hiding this comment.
Thanks for working on this!
…ed build on windows and macOS (microsoft#181191) * added notification in case of running a rosetta translated build * using app.runningUnderARM64Translation instead of system call * added download button to the download page in the wrong build notification * removed test call * Update src/vs/workbench/electron-sandbox/window.ts Co-authored-by: Robo <hop2deep@gmail.com> * Update src/vs/workbench/electron-sandbox/window.ts Co-authored-by: Robo <hop2deep@gmail.com> * code format * Update src/vs/workbench/electron-sandbox/window.ts Co-authored-by: Robo <hop2deep@gmail.com> --------- Co-authored-by: Robo <hop2deep@gmail.com>
This PR resolve #132598 feature request and adds a info notification when running a non native build on Apple silicon.