-
Notifications
You must be signed in to change notification settings - Fork 39.6k
Load 'node-pty' async #105345
Copy link
Copy link
Closed
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersperfperf-startupterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label
Milestone
Metadata
Metadata
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code Insidersperfperf-startupterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label
I see no reason why
node-ptyneeds to be loaded sync, as I think it is only used when an integrated terminal is opened. Loading it viaawait import('node-pty')could save some ms on startup://cc @jrieken