Conversation
Tyriar
suggested changes
Aug 26, 2020
| const args = shellLaunchConfig.args || []; | ||
| this._logService.trace('IPty#spawn', shellLaunchConfig.executable, args, options); | ||
| const ptyProcess = pty.spawn(shellLaunchConfig.executable!, args, options); | ||
| const ptyProcess = (await import('node-pty')).spawn(shellLaunchConfig.executable!, args, options); |
Contributor
There was a problem hiding this comment.
Looks good, can you also change the import to import type to make sure we don't accidentally import the code again?
Tyriar
approved these changes
Aug 26, 2020
Contributor
Tyriar
left a comment
There was a problem hiding this comment.
Good to merge after CI compile
Member
Author
|
@Tyriar oh nice, learnt something ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #105345