Skip to content

[vcpkg] Require a baseline when using constraints or overrides#8

Merged
vicroms merged 6 commits intomicrosoft:mainfrom
vicroms:versions/error-on-missing-baseline-with-constraints
Feb 11, 2021
Merged

[vcpkg] Require a baseline when using constraints or overrides#8
vicroms merged 6 commits intomicrosoft:mainfrom
vicroms:versions/error-on-missing-baseline-with-constraints

Conversation

@vicroms
Copy link
Copy Markdown
Member

@vicroms vicroms commented Feb 10, 2021

Report the following error when a user tries to use versioned dependencies ("version>=") or overrides without setting a baseline.
This validation is only needed when the versions feature flag is enabled.

The error message looks like this:

PS D:\demo> vcpkg install
D:\demo\vcpkg.json was rejected because it uses "overrides" or versioned dependencies ("version>=") without setting a "builtin-baseline".
See `vcpkg help versioning` for more information.

@vicroms vicroms requested a review from ras0219-msft February 11, 2021 02:51

if (!core_paragraph->builtin_baseline.has_value() && (has_overrides || has_versioned_dependencies))
{
return Strings::concat(fs::u8string(origin),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main suggestion for improving the error message would be to provide as specific of a message as possible, so split up the ||.

@vicroms vicroms merged commit 64415b1 into microsoft:main Feb 11, 2021
@vicroms vicroms deleted the versions/error-on-missing-baseline-with-constraints branch February 11, 2021 21:07
vicroms added a commit to vicroms/vcpkg-tool that referenced this pull request Aug 28, 2025
# This is the 1st commit message:

WIP

# The commit message #2 will be skipped:

# Fix build error

# The commit message microsoft#3 will be skipped:

# Implement bulk operation

# The commit message microsoft#4 will be skipped:

# Remove unused struct

# The commit message microsoft#5 will be skipped:

# Follow redirects

# The commit message microsoft#6 will be skipped:

# Get HTTP response code

# The commit message microsoft#7 will be skipped:

# Map URL response code to the correct index

# The commit message microsoft#8 will be skipped:

# Map URL response code to the correct index

# The commit message microsoft#9 will be skipped:

# Undo changes to workflows

# The commit message microsoft#10 will be skipped:

# Implement store to asset cache

# The commit message microsoft#11 will be skipped:

# handle file:// protocol

# The commit message microsoft#12 will be skipped:

# Implement try_download_file

# The commit message microsoft#13 will be skipped:

# Add missing calls to curl_easy_cleanup

# The commit message microsoft#14 will be skipped:

# Fix global init

# The commit message microsoft#15 will be skipped:

# Replace all calls in downloads.cpp and fix unit tests

# The commit message microsoft#16 will be skipped:

# use libcurl to submit metrics payload

# The commit message microsoft#17 will be skipped:

# Use Schannel on Windows

# The commit message microsoft#18 will be skipped:

# Apply suggestions from code review
#
# Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

# The commit message microsoft#19 will be skipped:

# Fix unit test

# The commit message microsoft#20 will be skipped:

# Change curl error messages

# The commit message microsoft#21 will be skipped:

# generate message map

# The commit message microsoft#22 will be skipped:

# Always call multi_remove_handle

# The commit message microsoft#23 will be skipped:

# Fix end-to-end tests

# The commit message microsoft#24 will be skipped:

# Cleanup header lists

# The commit message microsoft#25 will be skipped:

# curl global init order

# The commit message microsoft#26 will be skipped:

# Use external libcurl on non-Windows

# The commit message microsoft#27 will be skipped:

# Install libcurl4 dev package on Linux

# The commit message microsoft#28 will be skipped:

# Disable metrics by default in debug builds

# The commit message microsoft#29 will be skipped:

# Set user agent using CURLOPT_USERAGENT

# The commit message microsoft#30 will be skipped:

# curl initialization again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants