Skip to content

[vcpkg] Add experimental $X_VCPKG_ASSET_SOURCES for source caching#10

Merged
ras0219-msft merged 4 commits intomicrosoft:mainfrom
ras0219:dev/roschuma/azblob-src
Apr 20, 2021
Merged

[vcpkg] Add experimental $X_VCPKG_ASSET_SOURCES for source caching#10
ras0219-msft merged 4 commits intomicrosoft:mainfrom
ras0219:dev/roschuma/azblob-src

Conversation

@ras0219
Copy link
Copy Markdown
Contributor

@ras0219 ras0219 commented Feb 11, 2021

Tool changes for microsoft/vcpkg#13639.

See https://github.com/ras0219/vcpkg/blob/dev/roschuma/azblob-src/docs/users/config-environment.md#x_vcpkg_asset_sources for behavior docs.

The X_VCPKG_ASSET_SOURCES is designed to be similar to X_VCPKG_BINARY_SOURCES with the intent that they can share backends in the future.

@ras0219 ras0219 force-pushed the dev/roschuma/azblob-src branch from b6c709f to 312b7b7 Compare April 16, 2021 22:01
@ras0219 ras0219 changed the title [vcpkg] Add experimental $VCPKG_X_READWRITE_MIRROR_URL_TEMPLATE for source caching [vcpkg] Add experimental $X_VCPKG_ASSET_SOURCES for source caching Apr 16, 2021
@ras0219 ras0219 marked this pull request as ready for review April 19, 2021 18:21
Copy link
Copy Markdown
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I personally don't fully understand it. I'd prefer if someone else also reviewed.

{"x-package-info", &info},
{"x-history", &porthistory},
{"x-vsinstances", &vsinstances},
{"x-download", &xdownload},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add this command to vcpkg help?

@ras0219-msft ras0219-msft merged commit e0ad80f into microsoft:main Apr 20, 2021
@ras0219 ras0219 deleted the dev/roschuma/azblob-src branch April 20, 2021 23:03
vicroms added a commit to vicroms/vcpkg-tool that referenced this pull request Aug 28, 2025
# This is the 1st commit message:

WIP

# The commit message #2 will be skipped:

# Fix build error

# The commit message microsoft#3 will be skipped:

# Implement bulk operation

# The commit message microsoft#4 will be skipped:

# Remove unused struct

# The commit message microsoft#5 will be skipped:

# Follow redirects

# The commit message microsoft#6 will be skipped:

# Get HTTP response code

# The commit message microsoft#7 will be skipped:

# Map URL response code to the correct index

# The commit message microsoft#8 will be skipped:

# Map URL response code to the correct index

# The commit message microsoft#9 will be skipped:

# Undo changes to workflows

# The commit message microsoft#10 will be skipped:

# Implement store to asset cache

# The commit message microsoft#11 will be skipped:

# handle file:// protocol

# The commit message microsoft#12 will be skipped:

# Implement try_download_file

# The commit message microsoft#13 will be skipped:

# Add missing calls to curl_easy_cleanup

# The commit message microsoft#14 will be skipped:

# Fix global init

# The commit message microsoft#15 will be skipped:

# Replace all calls in downloads.cpp and fix unit tests

# The commit message microsoft#16 will be skipped:

# use libcurl to submit metrics payload

# The commit message microsoft#17 will be skipped:

# Use Schannel on Windows

# The commit message microsoft#18 will be skipped:

# Apply suggestions from code review
#
# Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

# The commit message microsoft#19 will be skipped:

# Fix unit test

# The commit message microsoft#20 will be skipped:

# Change curl error messages

# The commit message microsoft#21 will be skipped:

# generate message map

# The commit message microsoft#22 will be skipped:

# Always call multi_remove_handle

# The commit message microsoft#23 will be skipped:

# Fix end-to-end tests

# The commit message microsoft#24 will be skipped:

# Cleanup header lists

# The commit message microsoft#25 will be skipped:

# curl global init order

# The commit message microsoft#26 will be skipped:

# Use external libcurl on non-Windows

# The commit message microsoft#27 will be skipped:

# Install libcurl4 dev package on Linux

# The commit message microsoft#28 will be skipped:

# Disable metrics by default in debug builds

# The commit message microsoft#29 will be skipped:

# Set user agent using CURLOPT_USERAGENT

# The commit message microsoft#30 will be skipped:

# curl initialization again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants