Plumb DiagnosticContext into ToolCache / download / caching.#1842
Merged
Conversation
…cture. Unblocks microsoft/vcpkg#43309 by making --x-stderr-status actually work to `vcpkg fetch`
BillyONeal
commented
Nov 11, 2025
BillyONeal
commented
Nov 11, 2025
BillyONeal
commented
Nov 11, 2025
BillyONeal
commented
Nov 22, 2025
# Conflicts: # include/vcpkg/base/json.h # src/vcpkg/binarycaching.cpp # src/vcpkg/commands.ci.cpp
vicroms
approved these changes
Dec 8, 2025
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 3, 2026
In microsoft#1842 I broke portsdiff and z-changelog because the previous behavior checked only if git cat-file -t succeeded, not whether the target was actually a commit. By "fixing" that to actually check for commit that breaks tag inputs. Using -e and ^{commit} was suggested by gpt-5.3-codex but it was unable to make the other changes. Demonstration: ```console PS C:\Dev\vcpkg> .\vcpkg.exe z-changelog 2026.01.16 error: Invalid commit id: 2026.01.16 PS C:\Dev\vcpkg> C:\Dev\vcpkg-tool\out\build\Win-x64-Debug-WithArtifacts\vcpkg.exe z-changelog bogus error: Invalid commit id: bogus note: "C:\Program Files\Git\cmd\git.exe" -C "C:\Dev\vcpkg" -c core.autocrlf=false cat-file -e "bogus^{commit}" failed with exit code 128 fatal: Not a valid object name bogus^{commit} PS C:\Dev\vcpkg> C:\Dev\vcpkg-tool\out\build\Win-x64-Debug-WithArtifacts\vcpkg.exe z-changelog 2026.01.16 #### Total port count: 2765 #### Total port count per triplet (tested): LINK . . . ```
BillyONeal
added a commit
that referenced
this pull request
Mar 4, 2026
In #1842 I broke portsdiff and z-changelog because the previous behavior checked only if git cat-file -t succeeded, not whether the target was actually a commit. By "fixing" that to actually check for commit that breaks tag inputs. Using -e and ^{commit} was suggested by gpt-5.3-codex but it was unable to make the other changes. Demonstration: ```console PS C:\Dev\vcpkg> .\vcpkg.exe z-changelog 2026.01.16 error: Invalid commit id: 2026.01.16 PS C:\Dev\vcpkg> C:\Dev\vcpkg-tool\out\build\Win-x64-Debug-WithArtifacts\vcpkg.exe z-changelog bogus error: Invalid commit id: bogus note: "C:\Program Files\Git\cmd\git.exe" -C "C:\Dev\vcpkg" -c core.autocrlf=false cat-file -e "bogus^{commit}" failed with exit code 128 fatal: Not a valid object name bogus^{commit} PS C:\Dev\vcpkg> C:\Dev\vcpkg-tool\out\build\Win-x64-Debug-WithArtifacts\vcpkg.exe z-changelog 2026.01.16 #### Total port count: 2765 #### Total port count per triplet (tested): LINK . . . ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks microsoft/vcpkg#43309 by making
vcpkg fetch --x-stderr-statusactually work.