@JonLiu1993: Please mark this as reviewed so that we can get a review from the ms team.

@JavierMatosD @AugP @vicroms @ras0219-msft and I discussed today.

We are happy with the direction of the 4 tools in Billy's original list being changed to use fetch.

We observe that some tools in Billy's original 'unsafe' list might be OK to go through fetch, in particular assemblers like nasm or yasm. However, fetch doesn't already know about those tools, so the value in attempting to make a change like this in support of them is probably not worth it, so we aren't interested in going there right now.

list might be OK to go through fetch, in particular assemblers like nasm or yasm

Wouldn't this break the abi hash if the codegen is different for whatever reason between versions

@BillyONeal:

Any Idea:

CMake Error at scripts/test_ports/vcpkg-find-acquire-program/portfile.cmake:66 (message):
  The following programs do not exist:

     NUGET:  trying authoritative source https://dist.nuget.org/win-x86-commandline/v6.10.0/nuget.exe

  Successfully downloaded 71d7307b-nuget.exe, storing to
  https://vcpkgassetcachewus.blob.core.windows.net/cache/71d7307bb89de2df3811419c561efa00618a4c68e6ce481b0bdfc94c7c6c6d126a54eb26a0015686fabf99f109744ca41fead99e97139cdc86dde16a5ec3e7cf?***
  SECRET ***

  Store success

  D:\downloads\tools\nuget-6.10.0-windows\nuget.exe

     NUGET (interpreter): A suitable version of nuget was not found (required v6.10.0).

  Trying to download 71d7307b-nuget.exe using asset cache
  https://vcpkgassetcachewus.blob.core.windows.net/cache/71d7307bb89de2df3811419c561efa00618a4c68e6ce481b0bdfc94c7c6c6d126a54eb26a0015686fabf99f109744ca41fead99e97139cdc86dde16a5ec3e7cf?***
  SECRET ***

  Asset cache miss
Call Stack (most recent call first):
  scripts/ports.cmake:196 (include)

The rest looks like baseline regression

Wouldn't this break the abi hash if the codegen is different for whatever reason between versions

The assumption is that an assembler would not do that. To be clear, I'm not saying we should, I just wanted what was said to be recorded should this topic ever come up again.

@BillyONeal:

Any Idea:

This looks like something tried to set the entire vcpkg console output as the path to nuget.exe, including status explanations of what we are doing and why.

I observe that many of our existing uses of fetch run it more than once to try to avoid this happening, there might be tool bugs that need to be tackled here.

Pushed merge to pick up #43509 as the macs in the old pool are being shut down.

convert to draft until fetch only outputs the result to stdout (requires vcpkg-tool change)

Ok, now on OSX (Github actions runner image) I have a wonderful build error:

CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.

but the image itself states it has Ninja installed: https://github.com/actions/runner-images/blob/main/images/macos/macos-15-arm64-Readme.md#utilities