[freeimage, libwebp, OpenEXR, OpenVDB] Updates#5417
Conversation
… custom find_package script in favour of original Config files for cmake
…still maintaining backwards compatibility (there's an official one distributed with the package but it is completely different, for now it is avoided)
…to dev/viromer/5228
…to dev/viromer/5228
…to dev/viromer/5228
…into dev/viromer/5228
…to dev/viromer/5228
|
@vicroms thanks. So in the end this time was better a unique big PR, I agree :) |
|
I put some comments , mainly related to |
|
Thank you! |
|
|
||
| # Handle copyright | ||
| if("all" IN_LIST FEATURES) | ||
| file(REMOVE ${CURRENT_PACKAGES_DIR}/debug/bin/get_disto.exe) |
There was a problem hiding this comment.
shall we use ${CMAKE_EXECUTABLE_SUFFIX} for each tool, instead of ".exe", to be compatible with *nix?
| file(REMOVE ${DLLS}) | ||
| endforeach() | ||
| # NOTE: Only use ".exe" extension on Windows executables. | ||
| # Is there a cleaner way to do this? |
There was a problem hiding this comment.
yes, using the CMake default symbol ${CMAKE_EXECUTABLE_SUFFIX}
|
I think the review was not submitted?!? Anyway, thanks for the merge. Let's hope everything goes smooth in the next few days with people updating, this PR was very big. I will use it to continue working on OpenCV 4 👍 |
|
Break IlmImf-2_3.dll and OpenEXR static build |
This branch integrates changes from these PRs:
libwebp([libwebp] update to v1.0.2 #5210)openexr([OpenEXR] Update to v2.3.0 #5227)freeimage([freeimage] add compatibility with latest OpenEXR #5228)openvdb([OpenVDB] update to v6.0 #5265)In order to avoid causing regressions in the
masterbranch, it is necessary to merge all of these PRs together.@cenit please review these changes