Skip to content

[freeimage] add compatibility with latest OpenEXR#5228

Closed
cenit wants to merge 2 commits intomicrosoft:masterfrom
cenit:dev/cenit/freeimage
Closed

[freeimage] add compatibility with latest OpenEXR#5228
cenit wants to merge 2 commits intomicrosoft:masterfrom
cenit:dev/cenit/freeimage

Conversation

@cenit
Copy link
Copy Markdown
Contributor

@cenit cenit commented Jan 24, 2019

Due to #5227, some modifications are required in this port.
I also simplified it a lot in the meantime, recycling as much code as possible instead of having to maintain many doubles

@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Feb 14, 2019

@vicroms I confirm no problem on my side pulling this PR, merging it with #5210, #5227 and also #5226 (or rebasing this PR on the latest master, since #5226 has already been accepted). If it is done, then freeimage[core]:x64-windows is built correctly

log.txt

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Feb 20, 2019

@cenit
I had better luck pulling the PRs for libwebp and openexr into this branch (at least it builds locally).
On my previous attempt I started from the libwebp branch as base.

I'll trigger a CI build and let you know the results.

@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Feb 20, 2019

thanks! hoping for the best, please let me know in case you find anything that requires a modification

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Feb 21, 2019

@cenit
Shouldn't OpenEXR be disabled for UWP? The now removed port for ilmbase didn't support UWP, and now that it is embedded into OpenEXR doesn't the same restriction apply?

Wrong thread...

@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Feb 26, 2019

closed in favor of #5417

@cenit cenit closed this Feb 26, 2019
@cenit cenit deleted the dev/cenit/freeimage branch March 7, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants