Skip to content

[OpenEXR] Update to v2.3.0#5227

Closed
cenit wants to merge 5 commits intomicrosoft:masterfrom
cenit:dev/cenit/openexr
Closed

[OpenEXR] Update to v2.3.0#5227
cenit wants to merge 5 commits intomicrosoft:masterfrom
cenit:dev/cenit/openexr

Conversation

@cenit
Copy link
Copy Markdown
Contributor

@cenit cenit commented Jan 24, 2019

Upgrade the whole package:

  • move to github
  • update to v2.3.0
  • improve the FindOpenEXR.cmake, maintaining backwards compatibility (there's an official one distributed with the package but it is completely different, for now it is avoided)
  • remove the ilmbase port because now it is part of OpenEXR
  • enable installation of OpenEXR tools

cenit added 2 commits January 24, 2019 13:40
@cenit
[OpenEXR] Update to v2.3.0, enable tools, improve cmake module while …
a9ab727 
…still maintaining backwards compatibility (there's an official one distributed with the package but it is completely different, for now it is avoided)
@cenit
[OpenEXR] remove unused patches
9168539
@UnaNancyOwen
Copy link
Copy Markdown
Contributor

UnaNancyOwen commented Jan 24, 2019

[x] remove the ilmbase port because now it is part of OpenEXR

I agree. I think it is a good proposal than my pull request #4820. 👍
@ras0219-msft What do you think?

@cenit cenit mentioned this pull request Jan 24, 2019
Closed
@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Jan 24, 2019 •
edited
Loading

I just updated freeimage to comply with the new OpenEXR.
I noticed that also updates to alembic and to OpenVDB may be necessary, due to this upgrade...

edit: no update is necessary to alembic

@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Jan 30, 2019

this PR is necessary to build #5169 with all features

This was referenced Jan 30, 2019
Closed
Closed
@vicroms vicroms self-assigned this Feb 12, 2019
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Feb 21, 2019

@cenit
Shouldn't OpenEXR be disabled for UWP? The now removed port for ilmbase didn't support UWP, and now that it is embedded into OpenEXR doesn't the same restriction apply?

@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Feb 21, 2019 •
edited
Loading

you're right, there's a failure in ilmbase due to getenv and strerror function usage.
Sorry I didn't check all the ports with all the triplets, CI would be great to be exposed ;)
I am going to fix it asap

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Feb 21, 2019 •
edited
Loading

Great. I made a few changes so that OpenEXR can be built on Linux and MacOS, for now those changes are only on my branch.

I also pulled your changes to openvdb (PR #5265) as the removal of ilmbase would cause regressions otherwise, the CI build takes a while to finish, but hopefully this time it is successful.

@vicroms vicroms mentioned this pull request Feb 22, 2019
Merged
@cenit
Copy link
Copy Markdown
Contributor Author

cenit commented Feb 26, 2019

closed in favor of #5417

@cenit cenit closed this Feb 26, 2019
@cenit cenit deleted the dev/cenit/openexr branch March 7, 2019 13:31
@pezcode pezcode mentioned this pull request Sep 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vicroms vicroms

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cenit @UnaNancyOwen @vicroms