Skip to content

[ilmbase][openexr] Update IlmBase and OpenEXR to v2.3.0#4820

Closed
UnaNancyOwen wants to merge 4 commits intomicrosoft:masterfrom
UnaNancyOwen:update_openexr
Closed

[ilmbase][openexr] Update IlmBase and OpenEXR to v2.3.0#4820
UnaNancyOwen wants to merge 4 commits intomicrosoft:masterfrom
UnaNancyOwen:update_openexr

Conversation

@UnaNancyOwen
Copy link
Copy Markdown
Contributor

@UnaNancyOwen UnaNancyOwen commented Nov 25, 2018 •
edited
Loading

This pull request will update these port.

  • Update IlmBase port to IlmBase v2.3.0
  • Update OpenEXR port to OpenEXR v2.3.0

TODO: check all ports that dependent on these libraries.

@UnaNancyOwen
[ilmbase] Update to IlmBase v2.3.0
7020657 
Update IlmBase port to IlmBase v2.3.0.
@UnaNancyOwen
[openexr] Update to OpenEXR v2.3.0
b28fb3f 
Update OpenEXR port to OpenEXR v2.3.0.
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Nov 26, 2018

Thanks for the PR!

What's the purpose for adding all those .nuspec and .bat files in the patches?

@UnaNancyOwen
Copy link
Copy Markdown
Contributor Author

UnaNancyOwen commented Nov 27, 2018

What's the purpose for adding all those .nuspec and .bat files in the patches?

These patches (001-005) is difference between the current master and v2.3.0.
I reproduced current master by patch, because OpenEXR could not configure and build in v2.3.0.
It will include changes that are directly irrelevant to making possible to configure and build.
Should I extract minimal necessary changes?

openexr_

@UnaNancyOwen UnaNancyOwen mentioned this pull request Nov 29, 2018
Closed
4 tasks
@MVoz MVoz mentioned this pull request Dec 9, 2018
Closed
@UnaNancyOwen UnaNancyOwen mentioned this pull request Dec 12, 2018
Closed
3 tasks
@MVoz
Copy link
Copy Markdown
Contributor

MVoz commented Dec 25, 2018 

-- Performing post-build validation
DLLs should not be present in a static build, but the following DLLs were found:

    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/bin/Half-2_3.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/bin/Iex-2_3.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/bin/IexMath-2_3.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/bin/IlmThread-2_3.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/bin/Imath-2_3.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/debug/bin/Half-2_3_d.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/debug/bin/Iex-2_3_d.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/debug/bin/IexMath-2_3_d.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/debug/bin/IlmThread-2_3_d.dll
    E:/tools/vcpkg/packages/ilmbase_x64-windows-static/debug/bin/Imath-2_3_d.dll

There should be no bin\ directory in a static build, but E:\tools\vcpkg\packages\ilmbase_x64-windows-static\bin is present.
There should be no debug\bin\ directory in a static build, but E:\tools\vcpkg\packages\ilmbase_x64-windows-static\debug\bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

    if(VCPKG_LIBRARY_LINKAGE STREQUAL static)
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin)
    endif()

Found 2 error(s). Please correct the portfile:
    E:\tools\vcpkg\ports\ilmbase\portfile.cmake

add

    if(VCPKG_LIBRARY_LINKAGE STREQUAL static)
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin)
    endif()

@UnaNancyOwen
[ilmbase] Remove bin directories when static configuration
5007150 
Remove bin and debug/bin directories when static configuration.
@UnaNancyOwen
Copy link
Copy Markdown
Contributor Author

UnaNancyOwen commented Dec 25, 2018

@voskrese Please try again! Thanks,

@MVoz
Copy link
Copy Markdown
Contributor

MVoz commented Dec 25, 2018

@UnaNancyOwen
I have corrected, there was another mistake

e:\tools\vcpkg\buildtrees\openexr\src\v2.3.0-a634df73e5\ilmbase\imath\ImathNamespace.h(78): fatal error C1083: Cannot open include file: 'IlmBaseConfig.h': No such file or directory

@UnaNancyOwen
[openexr] Add patch for add ilmbase include path
999ce54 
Add patch for add ilmbase include path.
@UnaNancyOwen
Copy link
Copy Markdown
Contributor Author

UnaNancyOwen commented Dec 25, 2018

@voskrese Sorry, It was a little mistake. I fixed. Please confirm again.

@MVoz MVoz mentioned this pull request Dec 28, 2018
Merged
@UnaNancyOwen UnaNancyOwen mentioned this pull request Jan 24, 2019
Closed
5 tasks
@Rastaban
Copy link
Copy Markdown
Contributor

Rastaban commented Feb 28, 2019

Closing pull request because it looks like both ilmbase and openexr have been updated to the newer versions in other PRs.

@Rastaban Rastaban closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UnaNancyOwen @ras0219-msft @MVoz @Rastaban