Skip to content

[qt5-base] Fix build error on macOS 26 Tahoe#48298

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
phoerious:fix/macos26-opengl
Nov 17, 2025
Merged

[qt5-base] Fix build error on macOS 26 Tahoe#48298
BillyONeal merged 4 commits intomicrosoft:masterfrom
phoerious:fix/macos26-opengl

Conversation

@phoerious
Copy link
Copy Markdown
Contributor

@phoerious phoerious commented Nov 14, 2025 •
edited
Loading

macOS 26 Tahoe has removed AGL APIs from its SDK. AGL is not needed for building Qt, so we can just remove the dependency.
See: https://bugreports.qt.io/browse/QTBUG-137687

Fixes #47881

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@phoerious
Fix macOS 26 build error due to missing OpenGL.
efa7082 
macOS 26 Tahoe has removed OpenGL APIs from its SDK.
OpenGL is not needed for building Qt, so we can just
remove the dependency.
See: https://bugreports.qt.io/browse/QTBUG-137687

Fixes microsoft#47881
@phoerious
Copy link
Copy Markdown
Contributor Author

phoerious commented Nov 14, 2025

@microsoft-github-policy-service agree

BillyONeal
BillyONeal previously approved these changes Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this if the build passes but note that open source qt5 is end of life, as indicated in the linked qtbug.

ras0219-msft
ras0219-msft previously approved these changes Nov 14, 2025
View reviewed changes
@BillyONeal BillyONeal enabled auto-merge (squash) November 14, 2025 21:27
@phoerious
Copy link
Copy Markdown
Contributor Author

phoerious commented Nov 14, 2025

I know, but we still need to build with it.

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 14, 2025

I know, but we still need to build with it.

That's understood, and that's why we're merging it. I just want to put that disclaimer when we do so that next time someone shows up with a qt5 patch they aren't pointing to this going "well you did it here so why won't you do it with other patch". This patch is mostly only touching build system stuff so it's well within the kind of thing we would normally patch. But we aren't going to become effectively the new upstream maintainers for qt5; if a patch touches a lot of product code we are likely to not be able to merge that no matter how righteous.

It's just about if/when that happens people not being surprised / disappointed because they expected something implicitly :)

@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 15, 2025
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 15, 2025

My guess is that the build failures are baseline issues, looking at fixing that

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 15, 2025

The failing feature in all cases is qt5-base[icu]. Possible qt5-base (which is fairly old at this point) did not like #48073 ?

@BillyONeal BillyONeal dismissed stale reviews from ras0219-msft and themself via 00e8d70 November 15, 2025 04:51
Osyotr
Osyotr reviewed Nov 15, 2025
View reviewed changes
ports/qt5-base/portfile.cmake
OUTPUT_STRIP_TRAILING_WHITESPACE)
if(${OSX_SDK_VERSION} VERSION_GREATER_EQUAL 26)
# macOS 26 Tahoe has removed OpenGL APIs https://bugreports.qt.io/browse/QTBUG-137687
list(APPEND PATCHES patches/macos26-opengl.patch)
Copy link
Copy Markdown
Contributor

@Osyotr Osyotr Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If AGL is not used, why is this patch conditional?

Copy link
Copy Markdown
Contributor Author

@phoerious phoerious Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly whether how it's used and I didn't want to break something unnecessarily. The Qt issue only said that it's not needed.

@phoerious
Copy link
Copy Markdown
Contributor Author

phoerious commented Nov 15, 2025 •
edited
Loading

When I build locally, it asks me at some point to install autotools via homebrew. Buts it's been doing that for a while.

auto-merge was automatically disabled November 15, 2025 10:13

Head branch was pushed to by a user without write access

@BillyONeal BillyONeal merged commit 07ee15e into microsoft:master Nov 17, 2025
18 checks passed
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Nov 17, 2025

Thanks! Also thanks for the review @Osyotr !

phoerious added a commit to keepassxreboot/keepassxc that referenced this pull request Nov 18, 2025
@phoerious
Advance vcpkg baseline to fix macOS Qt building
da3b957 
Fixes Qt build errors on macOS 26 Tahoe.
See microsoft/vcpkg#48298
@phoerious phoerious mentioned this pull request Nov 18, 2025
Closed
@BillyONeal BillyONeal mentioned this pull request Nov 19, 2025
Merged
7 tasks
luadebug pushed a commit to luadebug/vcpkg that referenced this pull request Nov 21, 2025
@phoerious @BillyONeal @luadebug
[qt5-base] Fix build error on macOS 26 Tahoe (microsoft#48298)
930aadd 
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@luadebug luadebug mentioned this pull request Nov 21, 2025
Merged
phoerious added a commit to xboxones1/keepassxc that referenced this pull request Nov 22, 2025
@phoerious
Advance vcpkg baseline to fix macOS Qt building
3d45bbb 
Fixes Qt build errors on macOS 26 Tahoe.
See microsoft/vcpkg#48298
phoerious pushed a commit to xboxones1/keepassxc that referenced this pull request Nov 22, 2025
@xboxones1 @phoerious
Fix markdown type for >= QT 5.15.18
e5e2624 
Advance vcpkg baseline to fix macOS Qt building

Fixes Qt build errors on macOS 26 Tahoe.
See microsoft/vcpkg#48298
phoerious pushed a commit to keepassxreboot/keepassxc that referenced this pull request Nov 22, 2025
@xboxones1
Fix markdown type for >= QT 5.15.18 (#12654) and advance vcpkg baseline
f39e093 
- Fix markdown type for >= QT 5.15.18 (#12654) 

- Fix deprecation warnings about implicit capturing of "this"

- Advance vcpkg baseline to fix macOS Qt building
  Fixes Qt build errors on macOS 26 Tahoe.
  See microsoft/vcpkg#48298
phoerious pushed a commit to keepassxreboot/keepassxc that referenced this pull request Nov 22, 2025
@xboxones1 @phoerious
Fix markdown type for >= QT 5.15.18 (#12654) and advance vcpkg baseline
7f2cd6b 
- Fix markdown type for >= QT 5.15.18 (#12654)

- Fix deprecation warnings about implicit capturing of "this"

- Advance vcpkg baseline to fix macOS Qt building
  Fixes Qt build errors on macOS 26 Tahoe.
  See microsoft/vcpkg#48298
pull bot pushed a commit to TheTechOddBug/keepassxc that referenced this pull request Nov 22, 2025
@xboxones1 @pull
Fix markdown type for >= QT 5.15.18 (keepassxreboot#12654) and advanc…
f7c2935 
…e vcpkg baseline

- Fix markdown type for >= QT 5.15.18 (keepassxreboot#12654) 

- Fix deprecation warnings about implicit capturing of "this"

- Advance vcpkg baseline to fix macOS Qt building
  Fixes Qt build errors on macOS 26 Tahoe.
  See microsoft/vcpkg#48298
droidmonkey pushed a commit to keepassxreboot/keepassxc that referenced this pull request Nov 23, 2025
@xboxones1 @droidmonkey
Fix markdown type for >= QT 5.15.18 (#12654) and advance vcpkg baseline
dbcc6c4 
- Fix markdown type for >= QT 5.15.18 (#12654)

- Fix deprecation warnings about implicit capturing of "this"

- Advance vcpkg baseline to fix macOS Qt building
  Fixes Qt build errors on macOS 26 Tahoe.
  See microsoft/vcpkg#48298
phoerious pushed a commit to keepassxreboot/keepassxc that referenced this pull request Nov 23, 2025
@xboxones1 @phoerious
Fix markdown type for >= QT 5.15.18 (#12654) and advance vcpkg baseline
fdd3985 
- Fix markdown type for >= QT 5.15.18 (#12654)

- Fix deprecation warnings about implicit capturing of "this"

- Advance vcpkg baseline to fix macOS Qt building
  Fixes Qt build errors on macOS 26 Tahoe.
  See microsoft/vcpkg#48298
geiseri pushed a commit to geiseri/vcpkg that referenced this pull request Dec 18, 2025
@phoerious @BillyONeal @geiseri
[qt5-base] Fix build error on macOS 26 Tahoe (microsoft#48298)
3bbbd26 
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@phoerious phoerious mentioned this pull request Dec 20, 2025
Merged
7 tasks
hannpet pushed a commit to hannpet/keepassxc that referenced this pull request Jan 2, 2026
@xboxones1 @hannpet
Fix markdown type for >= QT 5.15.18 (keepassxreboot#12654) and advanc…
1b319ab 
…e vcpkg baseline

- Fix markdown type for >= QT 5.15.18 (keepassxreboot#12654) 

- Fix deprecation warnings about implicit capturing of "this"

- Advance vcpkg baseline to fix macOS Qt building
  Fixes Qt build errors on macOS 26 Tahoe.
  See microsoft/vcpkg#48298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@ras0219-msft ras0219-msft ras0219-msft left review comments

+1 more reviewer

@Osyotr Osyotr Osyotr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[qt5-base] build error on arm64-osx

4 participants

@phoerious @BillyONeal @Osyotr @ras0219-msft