[icu] Update to 78.1 by dg0yt · Pull Request #48073 · microsoft/vcpkg

dg0yt · 2025-11-01T18:23:09Z

To be used with C++17.

Port icu now skips AUTORECONF. It patches the pre-generated build system directly. Running autoreconf would require very recent autotools which are likely to be absent in many linux CI environments.

dg0yt · 2025-11-02T09:04:20Z

Related: artyom-beilis/cppcms#105

BillyONeal · 2025-11-04T22:15:14Z

/azp run

azure-pipelines · 2025-11-04T22:15:24Z

Azure Pipelines successfully started running 1 pipeline(s).

dg0yt · 2025-11-05T05:34:31Z

duckdb is unresolved. It is a strange package.
(Some) loadable extensions are static libs even in dynamic builds.
The dynamic duckdb lib includes these static libs (icu: C++17) which link the static duckdb lib which seems to be the trigger of the duplicate symbol.
Yes: The dynamic lib has different structure than the static lib.
And the dynamic lib is also built in the static triplet.

We could simply always build duckdb with C++17 (regardless of feature icu).
I can also resolve the CI issue by not building the dynamic lib in static triplets, but this would leave x64-linux-dynamic broken.

BillyONeal · 2025-11-07T21:40:02Z

We could simply always build duckdb with C++17 (regardless of feature icu).

That sounds reasonable to me.

I can also resolve the CI issue by not building the dynamic lib in static triplets, but this would leave x64-linux-dynamic broken.

IMO up to date ICU is more important than anything related to duckdb, and particularly more important than duckdb on a community triplet.

dg0yt · 2025-11-07T22:45:35Z

Port duckdb is more broadly broken (#48180). But this makes it even more acceptable to just go with C++17 for this port.

This reverts commit 033ed69.

dg0yt · 2025-11-09T16:17:22Z

Okay, the proper duckdb change should be ready now.

dg0yt · 2025-11-09T19:08:12Z

Great. I managed to move duckdb's duplicate definition problem out of the duckdb build into the downstream build (vcpkg-ci-duckdb).

FAILED: [code=1] main 
: && /usr/bin/c++ -fPIC -g  CMakeFiles/main.dir/main.c.o -o main  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libcore_functions_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libparquet_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libjemalloc_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libcore_functions_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libparquet_extension.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libjemalloc_extension.a  -ldl  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_fsst.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_fmt.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_pg_query.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_re2.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_miniz.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_utf8proc.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_hyperloglog.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_fastpforlib.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_skiplistlib.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_mbedtls.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_yyjson.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_zstd.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicui18n.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicuuc.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicudata.a && :
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a(icu_extension.cpp.o):(.rodata._ZN6duckdb11LogicalType7VARCHARE[_ZN6duckdb11LogicalType7VARCHARE]+0x0): multiple definition of `duckdb::LogicalType::VARCHAR'; /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a(ub_duckdb_common.cpp.o):(.rodata+0x2be9c): first defined here
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a(icu-dateadd.cpp.o):(.rodata._ZN6duckdb11LogicalType12TIMESTAMP_TZE[_ZN6duckdb11LogicalType12TIMESTAMP_TZE]+0x0): multiple definition of `duckdb::LogicalType::TIMESTAMP_TZ'; /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a(ub_duckdb_common.cpp.o):(.rodata+0x2be99): first defined here
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a(icu-dateadd.cpp.o):(.rodata._ZN6duckdb11LogicalType8INTERVALE[_ZN6duckdb11LogicalType8INTERVALE]+0x0): multiple definition of `duckdb::LogicalType::INTERVAL'; /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a(ub_duckdb_common.cpp.o):(.rodata+0x2bea0): first defined here
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a(icu-datepart.cpp.o):(.rodata._ZN6duckdb11LogicalType6BIGINTE[_ZN6duckdb11LogicalType6BIGINTE]+0x0): multiple definition of `duckdb::LogicalType::BIGINT'; /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a(ub_duckdb_common.cpp.o):(.rodata+0x2be8a): first defined here
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a(icu-datepart.cpp.o):(.rodata._ZN6duckdb11LogicalType6DOUBLEE[_ZN6duckdb11LogicalType6DOUBLEE]+0x0): multiple definition of `duckdb::LogicalType::DOUBLE'; /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a(ub_duckdb_common.cpp.o):(.rodata+0x2be90): first defined here
/usr/bin/ld: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libicu_extension.a(icu-timezone.cpp.o):(.rodata._ZN6duckdb11LogicalType7BOOLEANE[_ZN6duckdb11LogicalType7BOOLEANE]+0x0): multiple definition of `duckdb::LogicalType::BOOLEAN'; /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libduckdb_static.a(ub_duckdb_common.cpp.o):(.rodata+0x2be83): first defined here
collect2: error: ld returned 1 exit status

libicu_extension.a is C++17 with icu 78.1.
libduckdb_static.a is C++11 with default build settings.
So the situation is unchanged: Build all of duckdb with C++17 for new icu.

BillyONeal · 2025-11-11T20:31:23Z

/azp run

azure-pipelines · 2025-11-11T20:31:34Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal

Thanks!

Co-authored-by: Osyotr <Osyotr@users.noreply.github.com>

[icu] Update to 78.1

baf8e9f

dg0yt force-pushed the icu branch from a8c2757 to 9b1bce6 Compare November 1, 2025 19:56

Osyotr mentioned this pull request Nov 1, 2025

[icu] Update to 77.1 #44472

Closed

WIP [skip actions]

ee4bb18

dg0yt force-pushed the icu branch from 9b1bce6 to ee4bb18 Compare November 1, 2025 21:23

dg0yt and others added 2 commits November 2, 2025 07:34

WIP

4e111a8

[icu] Add C++17 flag to ICU::uc in vcpkg-cmake-wrapper

78feef1

Port cross data patch

b34b161

dg0yt force-pushed the icu branch from 08b8765 to fe2940a Compare November 2, 2025 10:27

dg0yt added 4 commits November 2, 2025 16:36

[cppcms] Update to 2.0.1

d9f0a62

Baseline cleanup

1f05a1d

Fix wasm

9218200

Merge branch 'cppcms' into icu

b45cd58

dg0yt force-pushed the icu branch from fe2940a to b45cd58 Compare November 2, 2025 15:53

[vcpkg-ci-duckdb] Build and run test executable

669d4cf

[duckdb] Do not remove bin [skip actions]

cbeac9e

dg0yt added 3 commits November 8, 2025 05:55

Add DUCKDB_STATIC_BUILD [skip actions]

9b81c80

[duckdb] Cleanup

35b842d

[duckdb] Force C++17 to resolve icu quirk

033ed69

dg0yt force-pushed the icu branch from 2c9d8c6 to 033ed69 Compare November 8, 2025 15:42

dg0yt marked this pull request as ready for review November 8, 2025 15:44

dg0yt added 3 commits November 9, 2025 11:04

[duckdb] Library linkage from triplet

0ccc04c

More corrections

360c513

Platform and more linkage control

06ca99d

Finish

41c96d4

dg0yt marked this pull request as draft November 9, 2025 16:12

dg0yt added 2 commits November 9, 2025 17:16

Revert "[duckdb] Force C++17 to resolve icu quirk"

41283f1

This reverts commit 033ed69.

Merge branch 'duckdb' into icu

9039890

[duckdb] Build with C++17

cdcab66

dg0yt mentioned this pull request Nov 9, 2025

[duckdb] Sanitize #48180

Merged

dg0yt marked this pull request as ready for review November 9, 2025 20:38

vicroms marked this pull request as draft November 11, 2025 02:17

dg0yt marked this pull request as ready for review November 11, 2025 06:09

Merge remote-tracking branch 'origin/master' into icu

c6fdd78

dg0yt force-pushed the icu branch from 77c806b to c6fdd78 Compare November 11, 2025 08:47

dg0yt closed this Nov 11, 2025

dg0yt reopened this Nov 11, 2025

dg0yt closed this Nov 11, 2025

dg0yt reopened this Nov 11, 2025

dg0yt closed this Nov 11, 2025

dg0yt reopened this Nov 11, 2025

BillyONeal approved these changes Nov 12, 2025

View reviewed changes

BillyONeal merged commit b02375d into microsoft:master Nov 12, 2025
21 checks passed

dg0yt deleted the icu branch November 13, 2025 05:36

BillyONeal mentioned this pull request Nov 15, 2025

[qt5-base] Fix build error on macOS 26 Tahoe #48298

Merged

7 tasks

geiseri pushed a commit to geiseri/vcpkg that referenced this pull request Dec 18, 2025

[icu] Update to 78.1 (microsoft#48073)

3c98abf

Co-authored-by: Osyotr <Osyotr@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[icu] Update to 78.1#48073

[icu] Update to 78.1#48073
BillyONeal merged 22 commits intomicrosoft:masterfrom
dg0yt:icu

dg0yt commented Nov 1, 2025 •

edited

Loading

Uh oh!

dg0yt commented Nov 2, 2025

Uh oh!

BillyONeal commented Nov 4, 2025

Uh oh!

azure-pipelines bot commented Nov 4, 2025

Uh oh!

dg0yt commented Nov 5, 2025

Uh oh!

BillyONeal commented Nov 7, 2025

Uh oh!

dg0yt commented Nov 7, 2025

Uh oh!

dg0yt commented Nov 9, 2025

Uh oh!

dg0yt commented Nov 9, 2025

Uh oh!

BillyONeal commented Nov 11, 2025

Uh oh!

azure-pipelines bot commented Nov 11, 2025

Uh oh!

BillyONeal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dg0yt commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg0yt commented Nov 2, 2025

Uh oh!

BillyONeal commented Nov 4, 2025

Uh oh!

azure-pipelines bot commented Nov 4, 2025

Uh oh!

dg0yt commented Nov 5, 2025

Uh oh!

BillyONeal commented Nov 7, 2025

Uh oh!

dg0yt commented Nov 7, 2025

Uh oh!

dg0yt commented Nov 9, 2025

Uh oh!

dg0yt commented Nov 9, 2025

Uh oh!

BillyONeal commented Nov 11, 2025

Uh oh!

azure-pipelines bot commented Nov 11, 2025

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dg0yt commented Nov 1, 2025 •

edited

Loading