[vcpkg] Add platform support for Solaris and illumos by trisk · Pull Request #45524 · microsoft/vcpkg

trisk · 2025-05-15T04:42:47Z

This add support for Solaris and illumos. Tested building several ports on illumos/amd64 (OmniOS with clang 18 from pkgsrc). Will be submitting fixes for ports that need them as separate PRs.
Depends on: microsoft/vcpkg-tool#1684

scripts/bootstrap.sh

In microsoft#45524 we the vcpkg team observe that z_vcpkg_select_default_vcpkg_chainload_toolchain should never be called after microsoft/vcpkg-tool#350 . We don't want to make a code review comment to leave it 'half broken', so we're submitting this change to make not editing that list consistent.

trisk · 2025-06-06T11:26:06Z

Interestingly, there is a new x64_osx test failure in the newly added tar check, suggesting it does not actually support archives with pax extended headers either. We normally use a prebuilt vcpkg-tool there, but I wonder what happens with the real release tarball.

BillyONeal · 2025-06-10T00:07:45Z

scripts/bootstrap.sh

        echo "Warning: -buildTests no longer has any effect; ignored."
    elif [ "$var" = "-skipDependencyChecks" ]; then
-        vcpkgSkipDependencyChecks="OFF"
+        vcpkgSkipDependencyChecks="ON"


#46216 Oh, I see, it "works" because two bugs happen together

BillyONeal · 2025-06-10T00:11:01Z

Interestingly, there is a new x64_osx test failure in the newly added tar check, suggesting it does not actually support archives with pax extended headers either. We normally use a prebuilt vcpkg-tool there, but I wonder what happens with the real release tarball.

vcpkg@CPPMAC-ARM64-05 test % curl -L -o test.tar.gz https://github.com/microsoft/vcpkg-tool/archive/refs/tags/2025-06-02.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2833k    0 2833k    0     0  2860k      0 --:--:-- --:--:-- --:--:-- 5392k
vcpkg@CPPMAC-ARM64-05 test % tar xf test.tar.gz
vcpkg@CPPMAC-ARM64-05 test % ls
test.tar.gz             vcpkg-tool-2025-06-02
vcpkg@CPPMAC-ARM64-05 test % tar --version
bsdtar 3.5.3 - libarchive 3.5.3 zlib/1.2.12 liblzma/5.4.3 bz2lib/1.0.8
vcpkg@CPPMAC-ARM64-05 test %

Something about the test doesn't seem to match up with 'reality' of extracting our tool sources?

trisk · 2025-06-10T10:07:54Z

Interestingly, there is a new x64_osx test failure in the newly added tar check, suggesting it does not actually support archives with pax extended headers either. We normally use a prebuilt vcpkg-tool there, but I wonder what happens with the real release tarball.
vcpkg@CPPMAC-ARM64-05 test % curl -L -o test.tar.gz https://github.com/microsoft/vcpkg-tool/archive/refs/tags/2025-06-02.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2833k    0 2833k    0     0  2860k      0 --:--:-- --:--:-- --:--:-- 5392k
vcpkg@CPPMAC-ARM64-05 test % tar xf test.tar.gz
vcpkg@CPPMAC-ARM64-05 test % ls
test.tar.gz             vcpkg-tool-2025-06-02
vcpkg@CPPMAC-ARM64-05 test % tar --version
bsdtar 3.5.3 - libarchive 3.5.3 zlib/1.2.12 liblzma/5.4.3 bz2lib/1.0.8
vcpkg@CPPMAC-ARM64-05 test %
Something about the test doesn't seem to match up with 'reality' of extracting our tool sources?

Updated the test to be libarchive compatible (and also search for bsdtar or star as shipped in pkgsrc), and fixed the error message from bootstrap.sh so it refers to tar instead of the last failed command.

BillyONeal

The added binary file makes me nervous but not an over my dead body thing yet.... what does this comment mean?

BillyONeal · 2025-06-12T19:45:12Z

/azp run

azure-pipelines · 2025-06-12T19:45:21Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2025-06-12T22:46:13Z

@ras0219-msft points out something: we require unzip anyway. Could we use the .zip instead of the .tar.gz to avoid the pax header thing entirely?

Otherwise we would prefer to use the actual sources as the test even if that makes the overall structure more complex so that we don't need to check in a binary file. (The xz situation is fresh in our minds)

trisk · 2025-06-16T18:45:08Z

The added binary file makes me nervous but not an over my dead body thing yet.... what does this comment mean?

This was a chunk of one of my public keys I was using in place of the hex string comments that I assume are git hashes in the original release archives, but I forgot to convert it to hex, should be: 52 comment=526c4a4652534251515578465531524a546b554b

trisk · 2025-06-16T19:01:18Z

@ras0219-msft points out something: we require unzip anyway. Could we use the .zip instead of the .tar.gz to avoid the pax header thing entirely?

Otherwise we would prefer to use the actual sources as the test even if that makes the overall structure more complex so that we don't need to check in a binary file. (The xz situation is fresh in our minds)

I think the zip archive should work fine. Another option is removing the first block from the tarball that contains the extra header with tail -c +1025, if we can expect that to be present consistently.

e.g.: tar xzf "$archive" || gunzip -c "$archive" | tail -c +1025 | tar xf -

BillyONeal · 2025-06-19T23:07:36Z

The build failures were fixed by #46016 so we will merge through them if this change is otherwise OK

BillyONeal · 2025-06-19T23:08:13Z

I think the zip archive should work fine. Another option is removing the first block from the tarball that contains the extra header with tail -c +1025, if we can expect that to be present consistently.

I think the zip is better because we don't really know how / if that metadata is setup

trisk · 2025-09-05T00:38:55Z

I think this ready for review, with the alteration to use the zip file instead of the tarball.

trisk · 2025-09-09T00:07:28Z

@LilyWangLL @BillyONeal any time to look at the current version of this?

# Conflicts: # scripts/vcpkg-tool-metadata.txt

BillyONeal

Thanks!

Mengna-Li assigned LilyWangLL May 15, 2025

LilyWangLL added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label May 15, 2025

trisk changed the title ~~Add platform support for Solaris and illumos~~ [vcpkg scripts] Add platform support for Solaris and illumos May 15, 2025

LilyWangLL previously approved these changes May 20, 2025

View reviewed changes

LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 20, 2025

BillyONeal reviewed May 22, 2025

View reviewed changes

scripts/bootstrap.sh Outdated Show resolved Hide resolved

BillyONeal mentioned this pull request May 22, 2025

Prohibit calls to z_vcpkg_select_default_vcpkg_chainload_toolchain #45649

Closed

vicroms added the depends:different-pr This PR or Issue depends on a PR which has been filed label May 27, 2025

trisk force-pushed the solaris-support branch 2 times, most recently from 8f865b3 to fb9af01 Compare June 6, 2025 10:47

BillyONeal reviewed Jun 10, 2025

View reviewed changes

BillyONeal removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. depends:different-pr This PR or Issue depends on a PR which has been filed labels Jun 10, 2025

BillyONeal marked this pull request as draft June 10, 2025 00:12

trisk force-pushed the solaris-support branch from fb9af01 to f5faf80 Compare June 10, 2025 10:06

trisk force-pushed the solaris-support branch from f5faf80 to a5c5107 Compare June 10, 2025 10:10

trisk marked this pull request as ready for review June 10, 2025 10:31

BillyONeal reviewed Jun 11, 2025

View reviewed changes

BillyONeal added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Jun 11, 2025

BillyONeal removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Jun 12, 2025

BillyONeal closed this Jun 13, 2025

BillyONeal reopened this Jun 13, 2025

trisk dismissed LilyWangLL’s stale review via a5c5107 June 13, 2025 19:21

BillyONeal marked this pull request as draft June 20, 2025 20:29

trisk force-pushed the solaris-support branch from a5c5107 to 9ac6e5a Compare June 27, 2025 21:42

BillyONeal mentioned this pull request Jun 30, 2025

[vcpkg script] Fix -skipDependencyChecks flag ignored in bootstrap.sh #46216

Merged

trisk force-pushed the solaris-support branch from 9ac6e5a to 3dbe5c2 Compare July 11, 2025 17:00

trisk force-pushed the solaris-support branch from 3dbe5c2 to de527fa Compare September 4, 2025 23:29

trisk changed the title ~~[vcpkg scripts] Add platform support for Solaris and illumos~~ [vcpkg] Add platform support for Solaris and illumos Sep 4, 2025

trisk marked this pull request as ready for review September 5, 2025 00:38

trisk added 3 commits September 5, 2025 15:26

[bootstrap] Use source zip instead of tarball to avoid pax headers

751c902

[bootstrap] Add dependency instructions for Solaris and illumos

0c957f1

[vcpkg] Add platform support for Solaris and illumos

873042e

trisk force-pushed the solaris-support branch from de527fa to 873042e Compare September 5, 2025 19:27

Merge remote-tracking branch 'origin/master' into HEAD

dd9474a

# Conflicts: # scripts/vcpkg-tool-metadata.txt

BillyONeal approved these changes Sep 16, 2025

View reviewed changes

BillyONeal enabled auto-merge (squash) September 16, 2025 07:04

vicroms approved these changes Sep 16, 2025

View reviewed changes

BillyONeal merged commit 4334d8b into microsoft:master Sep 18, 2025
17 of 18 checks passed

Conversation

trisk commented May 15, 2025

Uh oh!

Uh oh!

trisk commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

BillyONeal Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented Jun 10, 2025

Uh oh!

trisk commented Jun 10, 2025

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented Jun 12, 2025

Uh oh!

azure-pipelines bot commented Jun 12, 2025

Uh oh!

BillyONeal commented Jun 12, 2025

Uh oh!

trisk commented Jun 16, 2025

Uh oh!

trisk commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillyONeal commented Jun 19, 2025

Uh oh!

BillyONeal commented Jun 19, 2025

Uh oh!

trisk commented Sep 5, 2025

Uh oh!

trisk commented Sep 9, 2025

Uh oh!

BillyONeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

trisk commented Jun 6, 2025 •

edited

Loading

trisk commented Jun 16, 2025 •

edited

Loading