Skip to content

[vcpkg script] Fix -skipDependencyChecks flag ignored in bootstrap.sh#46216

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
mohiuddin-khan-shiam:master
Jun 30, 2025
Merged

[vcpkg script] Fix -skipDependencyChecks flag ignored in bootstrap.sh#46216
BillyONeal merged 2 commits intomicrosoft:masterfrom
mohiuddin-khan-shiam:master

Conversation

@mohiuddin-khan-shiam
Copy link
Copy Markdown
Contributor

Fix: -skipDependencyChecks flag ignored in bootstrap.sh

The -skipDependencyChecks option was ineffective:

  • The flag set vcpkgSkipDependencyChecks to OFF, identical to its default.
  • Dependency verification ran only when the variable was ON, the opposite of the intended logic.

This patch:

  • Sets vcpkgSkipDependencyChecks="ON" when the flag is passed.
  • Runs prerequisite checks only when vcpkgSkipDependencyChecks is OFF.

Users can now reliably bypass dependency checks, improving bootstrap success on constrained systems.

odiomarcelino and others added 2 commits June 29, 2025 18:53
…ile:///c:/Users/T2430514/Downloads/vcpkg/scripts/bootstrap.sh:0:0-0:0)

The `-skipDependencyChecks` option was ineffective:

* The flag set `vcpkgSkipDependencyChecks` to `OFF`, identical to its default.
* Dependency verification ran only when the variable was `ON`, the opposite of the intended logic.

This patch:

* Sets `vcpkgSkipDependencyChecks="ON"` when the flag is passed.
* Runs prerequisite checks only when `vcpkgSkipDependencyChecks` is **OFF**.

Users can now reliably bypass dependency checks, improving bootstrap success on constrained systems.

Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
Fix: -skipDependencyChecks flag ignored in bootstrap.sh
@Cheney-W Cheney-W self-assigned this Jun 30, 2025
@Cheney-W Cheney-W added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jun 30, 2025
@Cheney-W Cheney-W changed the title Fix: -skipDependencyChecks flag ignored in bootstrap.sh [vcpkg script] Fix -skipDependencyChecks flag ignored in bootstrap.sh Jun 30, 2025
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 30, 2025
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Related: #45524 (comment)

@BillyONeal BillyONeal merged commit 2f2b60d into microsoft:master Jun 30, 2025
18 checks passed
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants