Skip to content

[qt5-base] Fix hardcoded absolute paths in DLLs#3280

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
claudiofantacci:fix/qt5
Sep 20, 2018
Merged

[qt5-base] Fix hardcoded absolute paths in DLLs#3280
ras0219-msft merged 2 commits intomicrosoft:masterfrom
claudiofantacci:fix/qt5

Conversation

@claudiofantacci
Copy link
Copy Markdown
Contributor

@claudiofantacci claudiofantacci commented Apr 20, 2018

This PR changes the configuration parameters for the qt5-base port in order to fix #3248.

In order for the DLL to have the proper hardcoded absolute paths in the DLL, the deployment path, i.e. CURRENT_INSTALLED_DIR, must be passed at configure time instead of the intermediate vcpkg installation path, i.e. CURRENT_PACKAGES_DIR.

A thoroughful discussion can be found, and is still in progress, in #3248.

Fixes #3248

@claudiofantacci
Copy link
Copy Markdown
Contributor Author

claudiofantacci commented May 29, 2018

Ping for the present issue.
Please also have a look at issue #3248 that reports a discussion about Qt and vcpkg.

@claudiofantacci claudiofantacci mentioned this pull request Jun 12, 2018
Closed
@claudiofantacci
Copy link
Copy Markdown
Contributor Author

claudiofantacci commented Jun 25, 2018

Apologise for this new ping, my colleagues and I are just wondering whether this PR will be ever merged or not, just to take proper actions internally since issue #3248 is relevant for us.

@MikeGitb
Copy link
Copy Markdown
Contributor

MikeGitb commented Jul 30, 2018

Isn't CURRENT_PACKAGES_DIR the directory where cmake gets the data from when I use -DCMAKE_TOOLCHAIN_FILE=VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake ?

Would that still work?

@claudiofantacci
Copy link
Copy Markdown
Contributor Author

claudiofantacci commented Aug 1, 2018

Hi @MikeGitb, CMake looks for libraries in CURRENT_INSTALLED_DIR (i.e. <VCPKG folder>/installed/<arch>-windows folder) by using vcpkg toolchain.

This is the main problem when using Qt libraries as they have hardcoded paths into the DLL that are set to CURRENT_PACKAGES_DIR and not CURRENT_INSTALLED_DIR, as you can see from the patch I propose in this PR.

@huangqinjin huangqinjin mentioned this pull request Aug 3, 2018
Closed
@claudiofantacci
Copy link
Copy Markdown
Contributor Author

claudiofantacci commented Aug 29, 2018

This PR has been ignored for over 4 months now, and I would just like to understand the point of view of the maintainers about consuming Qt in a project outside the vcpkg build tree.
As of now, I have problem using it without shipping a qt.conf file.
Thanks!

@ras0219-msft ras0219-msft merged commit 90e627c into microsoft:master Sep 20, 2018
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Sep 20, 2018

Thanks for the PR and sorry for such a long merge delay!

@huangqinjin
Copy link
Copy Markdown
Contributor

huangqinjin commented Sep 21, 2018

There's no ${CURRENT_INSTALLED_DIR}/debug/qml installed . qmldir in debug mode should also point to ${CURRENT_INSTALLED_DIR}/qml.

@huangqinjin huangqinjin mentioned this pull request Sep 21, 2018
Closed
@claudiofantacci
Copy link
Copy Markdown
Contributor Author

claudiofantacci commented Sep 23, 2018

There's no ${CURRENT_INSTALLED_DIR}/debug/qml installed . qmldir in debug mode should also point to ${CURRENT_INSTALLED_DIR}/qml.

Hi @huangqinjin, thanks for pointing out this issue.
debug/qml was already present in the portfile and I left it unultered.
I can double check this as soon as I get back to office and submit a fix asap.

@claudiofantacci claudiofantacci mentioned this pull request Sep 24, 2018
Closed
ras0219-msft added a commit that referenced this pull request Oct 19, 2018
@ras0219-msft
[qt5-base] Partially revert #3280
4d603f2
@tronical
Copy link
Copy Markdown
Contributor

tronical commented Oct 19, 2018

This PR has been ignored for over 4 months now, and I would just like to understand the point of view of the maintainers about consuming Qt in a project outside the vcpkg build tree.
As of now, I have problem using it without shipping a qt.conf file.

Given that the paths presented at configure time are coded straight into Qt5Core.dll, I think you have only two options for a truly relocatable application binary:

  1. Install qt.conf next to the application, see http://doc.qt.io/qt-5/qt-conf.html
  2. Use windeployqt with a target path, that will patch Qt5Core.dll (binary wise) and change the prefix in there. Then use the Qt Install Framework to create an installer, which may also patch the binary at installation time on the user site.

I kind of prefer the first option, but both are valid depending on the use-case.

ras0219-msft pushed a commit that referenced this pull request Oct 22, 2018
@RobertBColton @ras0219-msft
Qt 5.11 and static build fixes (#4164)
473d63c 
* fix da qt5

* fix qt config duplication

* [qt5-base] Use vcpkg_extract_source_archive_ex
[sqlite3] Enable SQLITE_ENABLE_COLUMN_METADATA

* [qt5-*] Update sub-portfiles

* qt5-base WIP

* [qt5] Fix Could not find qmlcachegen.exe

* [qt5-activeqt] Fix SHA512

* [qt5-base] Fix static builds

* [qt5-base] Bump control version

* [qt5-base] Restore removal of qmake dependencies

* [qt5-base] Partially revert #3280

* [qt5-base][vcpkg_build_qmake] Fix Qt5Bootstrap.lib issues
@claudiofantacci
Copy link
Copy Markdown
Contributor Author

claudiofantacci commented Oct 23, 2018

Thanks @tronical, we actually use the second solution here 😄

The change that I proposed in this PR was to address a problem located only in vcpkg were you could not remove the Qt build folder because the hardcoded path were pointing to the build folder and not the installation folders.

@claudiofantacci claudiofantacci mentioned this pull request Dec 19, 2018
Closed
@claudiofantacci claudiofantacci mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not delete Qt buildtrees and packages folders! Qt no longer works.

5 participants

@claudiofantacci @MikeGitb @ras0219-msft @huangqinjin @tronical