Skip to content

[vcpkg] Update CMake to 3.25.0#28012

Merged
JavierMatosD merged 2 commits intomicrosoft:masterfrom
Neumann-A:update_cmake_3.25
Nov 29, 2022
Merged

[vcpkg] Update CMake to 3.25.0#28012
JavierMatosD merged 2 commits intomicrosoft:masterfrom
Neumann-A:update_cmake_3.25

Conversation

@Neumann-A
Copy link
Copy Markdown
Contributor

@Neumann-A Neumann-A commented Nov 25, 2022

required for updating VTK

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Nov 26, 2022 •
edited
Loading

ogre:arm64-windows:

CMake Error at Components/Bites/CMakeLists.txt:186 (qt6_wrap_cpp):
  Unknown CMake command "qt6_wrap_cpp".

looks like a baseline issue since depend-info ogre[*] doesn't show a qt dependency at all. (probably #27979)

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Nov 26, 2022

(probably #27979)

That's the plan.

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Nov 26, 2022

x64-linux: Failing libssh. Probably solved by #27973

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Nov 26, 2022

x64-windows-static-md:

FAILED: bin/solid-hardware5.exe 
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.25.0-windows\cmake-3.25.0-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=src\tools\solid-hardware\CMakeFiles\solid-hardware5.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\link.exe  @CMakeFiles\solid-hardware5.rsp  /out:bin\solid-hardware5.exe /implib:lib\solid-hardware5.lib /pdb:bin\solid-hardware5.pdb /version:0.0 /machine:x64 /nologo    /debug /INCREMENTAL /subsystem:console  && cd ."
LINK Pass 1: command "C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\link.exe @CMakeFiles\solid-hardware5.rsp /out:bin\solid-hardware5.exe /implib:lib\solid-hardware5.lib /pdb:bin\solid-hardware5.pdb /version:0.0 /machine:x64 /nologo /debug /INCREMENTAL /subsystem:console /MANIFEST /MANIFESTFILE:src\tools\solid-hardware\CMakeFiles\solid-hardware5.dir/intermediate.manifest src\tools\solid-hardware\CMakeFiles\solid-hardware5.dir/manifest.res" failed (exit code 1120) with the following output:
   Creating library lib\solid-hardware5.lib and object lib\solid-hardware5.exp
libimobiledevice-1.0.lib(idevice.c.obj) : error LNK2019: unresolved external symbol usbmuxd_subscribe referenced in function idevice_event_subscribe

looks also like a hidden dep to me cc @wrobelda

[8/1670] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DH5_BUILT_AS_STATIC_LIB -DOSG_LIBRARY_STATIC -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -ID:\buildtrees\osg\x64-windows-static-md-dbg\include -ID:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /W4 /wd4589 /wd4706 /wd4127 /wd4100 /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osg\CMakeFiles\osg.dir\AlphaFunc.cpp.obj /Fdsrc\osg\CMakeFiles\osg.dir\osg.pdb /FS -c D:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\src\osg\AlphaFunc.cpp
FAILED: src/osg/CMakeFiles/osg.dir/AlphaFunc.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\cl.exe   /TP -DH5_BUILT_AS_STATIC_LIB -DOSG_LIBRARY_STATIC -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -ID:\buildtrees\osg\x64-windows-static-md-dbg\include -ID:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /W4 /wd4589 /wd4706 /wd4127 /wd4100 /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Fosrc\osg\CMakeFiles\osg.dir\AlphaFunc.cpp.obj /Fdsrc\osg\CMakeFiles\osg.dir\osg.pdb /FS -c D:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\src\osg\AlphaFunc.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W4'
D:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\include\osg/GLExtensions(323): error C2061: syntax error: identifier 'GLint64'
D:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\include\osg/GLExtensions(324): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
D:\buildtrees\osg\src\raph-3.6.5-41fa3cfd98.clean\include\osg/GLExtensions(324): error C2143: syntax error: missing ',' before '*'

looks like a opengl header define conflict.

None of the observed failures seems to be related to this PR and are all baseline issues.

@JonLiu1993 JonLiu1993 changed the title Update CMake to 3.25.0 [scripts] Update CMake to 3.25.0 Nov 28, 2022
@JonLiu1993 JonLiu1993 added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:different-pr This PR or Issue depends on a PR which has been filed labels Nov 28, 2022
@JonLiu1993
Copy link
Copy Markdown
Contributor

JonLiu1993 commented Nov 28, 2022

Depends on PR #27973

@JonLiu1993 JonLiu1993 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 29, 2022
@JonLiu1993 JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 29, 2022
@JonLiu1993 JonLiu1993 changed the title [scripts] Update CMake to 3.25.0 [vcpkg] Update CMake to 3.25.0 Nov 29, 2022
@Neumann-A Neumann-A mentioned this pull request Nov 29, 2022
Merged
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Nov 29, 2022

Thank you!

@JavierMatosD JavierMatosD merged commit 1885879 into microsoft:master Nov 29, 2022
@Neumann-A Neumann-A deleted the update_cmake_3.25 branch November 29, 2022 19:47
@mrowrpurr mrowrpurr mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neumann-A @dg0yt @JonLiu1993 @JavierMatosD