Skip to content

[baseline][libssh] Update to latest commit#27973

Merged
JavierMatosD merged 11 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/baseline_libssh
Nov 28, 2022
Merged

[baseline][libssh] Update to latest commit#27973
JavierMatosD merged 11 commits intomicrosoft:masterfrom
LilyWangLL:dev/LilyWang/baseline_libssh

Conversation

@LilyWangLL
Copy link
Copy Markdown
Contributor

@LilyWangLL LilyWangLL commented Nov 23, 2022 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    Update libssh to latest commit, fix libssh fetch error on Linux.
/usr/bin/git fetch https://git.libssh.org/projects/libssh.git e8322817a9e5aaef0698d779ddd467a209a85d85 --depth 1 -n
error: Server does not allow request for unadvertised object e8322817a9e5aaef0698d779ddd467a209a85d85

All features test pass on x64-windows.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 23, 2022
github-actions[bot]
github-actions bot previously approved these changes Nov 23, 2022
View reviewed changes
@LilyWangLL LilyWangLL marked this pull request as ready for review November 24, 2022 02:11
@LilyWangLL LilyWangLL requested a review from Cheney-W November 24, 2022 02:11
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 24, 2022
Cheney-W
Cheney-W previously approved these changes Nov 24, 2022
View reviewed changes
dg0yt
dg0yt suggested changes Nov 24, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
View reviewed changes
@Cheney-W Cheney-W removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Nov 24, 2022
View reviewed changes
@LilyWangLL
Copy link
Copy Markdown
Contributor Author

LilyWangLL commented Nov 24, 2022

The upstream has latest commit yesterday, so this port install failed on Linux again. I changed to fetch latest commit. Do we have method to handle this problem?
cc @BillyONeal

@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Nov 24, 2022

The upstream has latest commit yesterday, so this port install failed on Linux again. I changed to fetch latest commit. Do we have method to handle this problem?

Yes we do. It is called FETCH_REF master (or however the libssh branch is called)

@Cheney-W Cheney-W mentioned this pull request Nov 25, 2022
Merged
@LilyWangLL
Copy link
Copy Markdown
Contributor Author

LilyWangLL commented Nov 25, 2022

The upstream has latest commit yesterday, so this port install failed on Linux again. I changed to fetch latest commit. Do we have method to handle this problem?

Yes we do. It is called FETCH_REF master (or however the libssh branch is called)

Done, thanks for your help.

@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 25, 2022
@Neumann-A Neumann-A mentioned this pull request Nov 26, 2022
Merged
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Nov 28, 2022
Merged
This was referenced Nov 28, 2022
Merged
Merged
@JavierMatosD
Copy link
Copy Markdown
Contributor

JavierMatosD commented Nov 28, 2022

Thank you!

@JavierMatosD JavierMatosD merged commit 1796ce2 into microsoft:master Nov 28, 2022
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Dec 2, 2022
Merged
@FrankXie05 FrankXie05 mentioned this pull request Dec 19, 2022
Merged
@LilyWangLL LilyWangLL deleted the dev/LilyWang/baseline_libssh branch December 19, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+2 more reviewers

@dg0yt dg0yt dg0yt requested changes

@Cheney-W Cheney-W Cheney-W left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Cheney-W Cheney-W

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LilyWangLL @Neumann-A @JavierMatosD @dg0yt @Cheney-W